allow overlapping sandbox with run_cmd#680
Merged
Kipok merged 3 commits intoNVIDIA-NeMo:mainfrom Aug 16, 2025
Merged
Conversation
SeanNaren
force-pushed
the
feat/sandbox_eval_fix
branch
from
ff16378 to
ed67f83
Compare
Kipok
approved these changes
Aug 16, 2025
shtoshni
pushed a commit
that referenced
this pull request
Aug 16, 2025
Signed-off-by: SeanNaren <snarenthiran@nvidia.com> Signed-off-by: Shubham Toshniwal <stoshniwal@nvidia.com>
SeanNaren
added a commit
to SeanNaren/NeMo-Skills
that referenced
this pull request
Aug 18, 2025
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
wedu-nvidia
pushed a commit
that referenced
this pull request
Aug 22, 2025
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
wasiahmad
pushed a commit
that referenced
this pull request
Oct 1, 2025
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes requirement of running the sandbox whilst the command passed to run_cmd is executing.