Skip to content

Enable system_message for openai prompt format #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kipok merged 1 commit into from
Aug 14, 2025
Merged

Enable system_message for openai prompt format #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions nemo_skills/inference/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,6 @@ def _post_init_validate_params(self):
if self.prompt_format == "openai":
assert self.prompt_config is None, "prompt_config is not supported for prompt_format == 'openai'"
assert self.prompt_template is None, "prompt_template is not supported for prompt_format == 'openai'"
assert self.system_message is None, "system_message is not supported for prompt_format == 'openai'"
else:
assert self.prompt_config is not None, "prompt_config is required when prompt_format == 'ns'"
for param, default_value in self._get_disallowed_params():
Expand Down Expand Up @@ -305,7 +304,7 @@ def log_example_prompt(self, data):

if self.cfg.prompt_format == "openai":
# print the prompt in openai format
LOG.info("Example prompt in OpenAI format: \nData dictionary: %s", data_point)
LOG.info("Example prompt in OpenAI format: %s", self.fill_prompt(data_point, data))
return

if self.cfg.multi_turn_key is None:
Expand Down Expand Up @@ -388,6 +387,11 @@ def fill_prompt(self, data_point, data):
if self.cfg.prompt_format == "openai":
if self.cfg.prompt_suffix:
data_point["messages"][-1]["content"] += self.cfg.prompt_suffix
if self.cfg.system_message:
if data_point["messages"][0]["role"] != "system":
data_point["messages"].insert(0, {"role": "system", "content": self.cfg.system_message})
else:
data_point["messages"][0]["content"] = self.cfg.system_message
return data_point["messages"]

total_code_executions_in_prompt = self.cfg.total_code_executions_in_prompt
Expand Down