Skip to content

Fix type mismatch for max code executions #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kipok merged 1 commit into from
Aug 13, 2025
Merged

Fix type mismatch for max code executions #665

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions nemo_skills/inference/generate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -458,8 +458,7 @@ async def process_single_datapoint(self, data_point, all_data):

if self.cfg.code_execution:
if self.cfg.override_max_code_executions and self.cfg.total_code_executions_in_prompt is not None:
max_code_executions_values = [data_point['total_code_executions']]
generation_params['max_code_executions'] = max_code_executions_values
generation_params['max_code_executions'] = data_point['total_code_executions']

return await self.llm.generate_async(**generation_params)

Expand Down
4 changes: 0 additions & 4 deletions nemo_skills/inference/model/code_execution.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,20 +13,16 @@
# limitations under the License.


import asyncio
import copy
import logging
import time
from concurrent.futures import ThreadPoolExecutor
from dataclasses import field

from nemo_skills.code_execution import extract_code_to_execute, format_code_output
from nemo_skills.code_execution.sandbox import Sandbox
from nemo_skills.inference.model.utils import trim_after_stop_phrases
from nemo_skills.utils import get_logger_name, nested_dataclass

from .base import BaseModel
from .utils import trim_after_stop_phrases

LOG = logging.getLogger(get_logger_name(__file__))

Expand Down