Skip to content

Small fix for mrcr prepare.py #662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kipok merged 1 commit into from
Aug 12, 2025
Merged

Small fix for mrcr prepare.py #662

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nemo_skills/dataset/mrcr/prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def count_n_tokens(messages: list[dict]) -> int:
def write_data_to_file(output_file, data, max_context_window, needles_subset):
with open(output_file, "wt", encoding="utf-8") as fout:
for idx, entry in tqdm(enumerate(data), desc=f"Writing {output_file.name}"):
messages = json.loads(entry["prompt"])
messages = json.loads(entry.pop("prompt"))

if entry['n_needles'] not in needles_subset:
print(f"Skipping {idx} because it has {entry['n_needles']} needle")
Expand All @@ -56,7 +56,7 @@ def write_data_to_file(output_file, data, max_context_window, needles_subset):
print(f"Skipping {idx} because it has {n_tokens} tokens")
continue

entry['messages'] = entry.pop('prompt')
entry['messages'] = messages
entry['expected_answer'] = entry.pop('answer')
entry['n_tokens'] = n_tokens
json.dump(entry, fout)
Expand Down