Skip to content

Fix a small bug in generation with chunks#661

Merged
Kipok merged 1 commit intomainfrom
fchen97/generation_job_submit_fix
Aug 12, 2025
Merged

Fix a small bug in generation with chunks#661
Kipok merged 1 commit intomainfrom
fchen97/generation_job_submit_fix

Conversation

@fchen97
Copy link
Contributor

@fchen97 fchen97 commented Aug 11, 2025

When generating with large number of chunks, the command may exceed maximum length. Fix the bug to batch the commands.

Signed-off-by: Feng Chen <42473790+fchen97@users.noreply.github.com>
@fchen97 fchen97 requested a review from Kipok August 11, 2025 23:43
Copy link
Collaborator

@Kipok Kipok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Kipok Kipok merged commit 3d96e31 into main Aug 12, 2025
4 checks passed
@fchen97 fchen97 deleted the fchen97/generation_job_submit_fix branch August 12, 2025 00:06
SeanNaren pushed a commit to SeanNaren/NeMo-Skills that referenced this pull request Aug 15, 2025
Signed-off-by: Feng Chen <42473790+fchen97@users.noreply.github.com>
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
shtoshni pushed a commit that referenced this pull request Aug 15, 2025
Signed-off-by: Feng Chen <42473790+fchen97@users.noreply.github.com>
Signed-off-by: Shubham Toshniwal <stoshniwal@nvidia.com>
SeanNaren pushed a commit to SeanNaren/NeMo-Skills that referenced this pull request Aug 18, 2025
Signed-off-by: Feng Chen <42473790+fchen97@users.noreply.github.com>
Signed-off-by: SeanNaren <snarenthiran@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Oct 1, 2025
Signed-off-by: Feng Chen <42473790+fchen97@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants