Skip to content

Support source_lang param for translation recipe #1290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 2 commits into from
Mar 4, 2026
+3 −2
Merged

Support source_lang param for translation recipe #1290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7a3792
Support source_lang param for translation recipe
prasoonvarshney Mar 2, 2026
65ae505
Merge branch 'main' into feature/translation_source_lang
gwarmstrong Mar 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions recipes/translation/translate_jsonl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ def full_language_name(lang_code: str) -> str:

@nested_dataclass(kw_only=True)
class TranslationConfig(GenerationTaskConfig):
source_lang: str = "en"
target_lang: str = "zh"
use_skipme: bool = False
fields_to_translate: List[str] = field(default_factory=lambda: ["conversations.*.value"])
Expand Down Expand Up @@ -223,7 +224,7 @@ def preprocess_data(self, data):
async_position = 0
for text in all_translatable_lines:
translation_data_point = {
"source_lang": full_language_name("en"),
"source_lang": full_language_name(self.cfg.source_lang),
"target_lang": full_language_name(self.cfg.target_lang),
"src": text,
self.cfg.async_position_key: async_position,
Expand All @@ -242,7 +243,7 @@ def log_example_prompt(self, data):
data[0]
if isinstance(data[0], dict) and "src" in data[0]
else {
"source_lang": "English",
"source_lang": full_language_name(self.cfg.source_lang),
"target_lang": full_language_name(self.cfg.target_lang),
"src": "Sample text to translate",
}
Expand Down