Skip to content

Fix os.getlogin() crash in ns setup #1289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 5 commits into from
Mar 3, 2026
Merged

Fix os.getlogin() crash in ns setup #1289

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2dec725
Add tests exposing os.getlogin() crash in ns setup (#1269)
gwarmstrong Mar 3, 2026
13e543d
Fix os.getlogin() crash in ns setup for containers/VMs (#1269)
gwarmstrong Mar 3, 2026
c364d71
Remove overbuilt test_setup.py tests
gwarmstrong Mar 3, 2026
bc04c41
Merge branch 'main' into georgea/fix-issue-1269
gwarmstrong Mar 3, 2026
c5e9f82
Merge branch 'main' into georgea/fix-issue-1269
gwarmstrong Mar 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions nemo_skills/pipeline/setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import getpass
import os
import subprocess
from pathlib import Path
Expand Down Expand Up @@ -103,7 +104,7 @@ def setup():
"as well as for your models (e.g. /trt_models, /hf_models).\n"
"If you're setting up a Slurm config, make sure to use the cluster paths here.\n"
"What mounts would you like to add? (comma separated)",
default=f"/home/{os.getlogin()}:/workspace" if config_type == "local" else None,
default=f"{os.path.expanduser('~')}:/workspace" if config_type == "local" else None,
)

# parse mounts early so we can validate HF_HOME against them
Expand Down Expand Up @@ -172,7 +173,7 @@ def setup():
ssh_tunnel["host"] = typer.prompt("\nWhat is the ssh hostname of your cluster?")
ssh_tunnel["user"] = typer.prompt(
"\nWhat is your ssh username on the cluster?",
default=os.getlogin(),
default=getpass.getuser(),
)
default_key = os.path.expanduser("~/.ssh/id_rsa")
ssh_tunnel["identity"] = typer.prompt(
Expand Down