Skip to content

CritPt generation add prompt_format=None #1280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 2 commits into from
Feb 27, 2026
Merged

CritPt generation add prompt_format=None #1280

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
314afa1
add prompt_format=None
jiacheng-xu Feb 27, 2026
629bb26
Merge branch 'main' into fix/critpt-bug
gwarmstrong Feb 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_skills/inference/eval/critpt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def __init__(self, cfg: GenerationTaskConfig):
self.turn1_prompt_instance = get_prompt(prompt_config=self.prompt_config_turn1)
self.turn2_prompt_instance = get_prompt(prompt_config=self.prompt_config_turn2)

def fill_prompt(self, data_point, data):
def fill_prompt(self, data_point, data, prompt_format=None):
"""Build messages list for turn 1, or return pre-built messages for turn 2."""
# If messages are already provided (turn 2), just return them
if "messages" in data_point:
Expand Down