Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions nemo_skills/dataset/aime26/__init__.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
# Copyright (c) 2024, NVIDIA CORPORATION. All rights reserved.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Copyright year mismatch with prepare.py.

This file says Copyright (c) 2024 while prepare.py says Copyright (c) 2026. Since this is a new file for a 2026 benchmark, the year should likely be 2026 to be consistent.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@nemo_skills/dataset/aime26/__init__.py` at line 1, Update the copyright year
in the module header of nemo_skills/dataset/aime26/__init__.py from 2024 to 2026
to match prepare.py; open the file, locate the top-of-file copyright comment
(the string "Copyright (c) 2024, NVIDIA CORPORATION.  All rights reserved."),
and change the year to 2026 so both files use the same copyright year.

#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

# settings that define how evaluation should be done by default (all can be changed from cmdline)
DATASET_GROUP = "math"
METRICS_TYPE = "math"
GENERATION_ARGS = "++prompt_config=generic/math ++eval_type=math"
50 changes: 50 additions & 0 deletions nemo_skills/dataset/aime26/prepare.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
# Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.

import argparse
import json
from pathlib import Path

from datasets import load_dataset
from tqdm import tqdm


def format_entry(entry):
return {
"id": f"aime26-{entry['problem_idx']}",
"problem": entry["problem"],
"expected_answer": str(entry["answer"]),
}


def write_data_to_file(output_file, data):
with open(output_file, "wt", encoding="utf-8") as fout:
for entry in tqdm(data, desc=f"Writing {output_file.name}"):
json.dump(format_entry(entry), fout, ensure_ascii=False)
fout.write("\n")


def main(args):
dataset = load_dataset("MathArena/aime_2026", split="train")
data_dir = Path(__file__).absolute().parent
data_dir.mkdir(exist_ok=True)
output_file = data_dir / f"{args.split}.jsonl"
write_data_to_file(output_file, dataset)
Comment on lines +38 to +43

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Check if other prepare.py scripts in this repo also load a different split than the output name
rg -n 'load_dataset.*split=' --glob 'nemo_skills/dataset/*/prepare.py' -A2 -B2

Repository: NVIDIA-NeMo/Skills

Length of output: 10510


Add a clarifying comment explaining the hardcoded split.

The dataset is loaded with split="train" (line 39) regardless of args.split, but the output file is named {args.split}.jsonl. This pattern—where the HuggingFace split differs from the output filename—appears elsewhere in the codebase (e.g., simpleqa), suggesting it's intentional because the HuggingFace dataset only exposes a train split but the benchmark treats it as a test set. A brief comment explaining this would prevent future confusion.

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@nemo_skills/dataset/aime26/prepare.py` around lines 38 - 43, In main(), the
call load_dataset("MathArena/aime_2026", split="train") is hardcoded to "train"
while the output file is named using args.split (output_file = data_dir /
f"{args.split}.jsonl"); add a brief clarifying comment above the load_dataset
line (inside the main function) explaining that the HuggingFace dataset only
exposes a single "train" split but the benchmark uses that data as the target
split (e.g., test/validation), so we intentionally load "train" regardless of
args.split to produce the appropriately named output file.



if __name__ == "__main__":
parser = argparse.ArgumentParser()
parser.add_argument("--split", default="test", choices=("test",), help="Dataset split to process.")
args = parser.parse_args()
main(args)