Merged
Conversation
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
…erabbit fixes Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
…al_full() in BIRD bench Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
gwarmstrong
reviewed
Dec 19, 2025
gwarmstrong
reviewed
Dec 19, 2025
docs/evaluation/code.md
Outdated
Comment on lines
+331
to
+333
| This will download and unpack a file into `<output_directory>/dev_20240627`, which contains the BIRD dev manifest, table information, and database schemas. By default, `output_directory` will be under `nemo_skills/dataset/birdbench/`, though this can be changed via command line argument. | ||
|
|
||
| The script will also process the original manifest into `<output_directory>/dev.jsonl`, which will be the input for evaluation. |
Collaborator
There was a problem hiding this comment.
is this needed now that we have data_dir? The rest of this is pretty consistent across evaluations.
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Contributor
Greptile SummaryAdds BIRD benchmark support for text-to-SQL evaluation with SQL execution accuracy metrics. The implementation includes data preparation scripts that download and process the BIRD dataset, an evaluator that compares SQL execution results with a 30-second timeout, and metrics calculation grouped by difficulty levels (simple/moderate/challenging). The changes properly integrate with the existing evaluation framework by registering the new evaluator and metrics classes, and include comprehensive documentation for setup and usage. Confidence Score: 5/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant User
participant ns_prepare_data
participant Download as wget/zipfile
participant SQLite as sqlite3
participant ns_eval
participant BirdEvaluator
participant LLM as Model
participant BirdMetrics
User->>ns_prepare_data: prepare_data birdbench
ns_prepare_data->>Download: Download dev.zip from bird-bench
Download-->>ns_prepare_data: dev_20240627/
ns_prepare_data->>SQLite: Extract table schemas via iterdump()
SQLite-->>ns_prepare_data: Table definitions + sample data
ns_prepare_data->>ns_prepare_data: Format entries to dev.jsonl
ns_prepare_data-->>User: Data ready
User->>ns_eval: eval --benchmarks=birdbench
ns_eval->>LLM: Generate SQL from question + sql_context
LLM-->>ns_eval: Generated SQL in ```sql blocks
ns_eval->>BirdEvaluator: eval_single(data_point)
BirdEvaluator->>BirdEvaluator: Extract SQL with regex
BirdEvaluator->>BirdEvaluator: Remove comments (-- and /* */)
BirdEvaluator->>SQLite: Execute predicted SQL
SQLite-->>BirdEvaluator: predicted_results
BirdEvaluator->>SQLite: Execute ground truth SQL
SQLite-->>BirdEvaluator: ground_truth_results
BirdEvaluator->>BirdEvaluator: Compare sets (timeout: 30s)
BirdEvaluator-->>ns_eval: res = 0 or 1
ns_eval->>BirdMetrics: update(predictions)
BirdMetrics->>BirdMetrics: Group by difficulty (simple/moderate/challenging)
BirdMetrics-->>User: Accuracy per difficulty + total_acc
|
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
gwarmstrong
approved these changes
Jan 7, 2026
blahblahasdf
pushed a commit
to blahblahasdf/Skills
that referenced
this pull request
Jan 8, 2026
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: dlord <dlord@nvidia.com> # Conflicts: # nemo_skills/evaluation/evaluator/__init__.py
hsiehjackson
pushed a commit
that referenced
this pull request
Jan 13, 2026
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Mar 18, 2026
Signed-off-by: Jocelyn Huang <jocelynh@nvidia.com> Signed-off-by: dgitman <dgitman@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added BIRD's SQL execution accuracy metric to code generation benchmarks.
Also added some documentation on how to download/process data and run the benchmark.
Original dataset website: https://github.com/AlibabaResearch/DAMO-ConvAI/tree/main/bird
SQL execution from BIRD: https://github.com/AlibabaResearch/DAMO-ConvAI/blob/main/bird/llm/src/evaluation.py
Summary by CodeRabbit
New Features
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.