Skip to content

replace raise error with LOG.warning in AA LCR dataset prepare #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 3 commits into from
Dec 17, 2025
Merged

replace raise error with LOG.warning in AA LCR dataset prepare #1119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8380bbf
replace raise error with LOG.warning in AA LCR dataset prepare
anowaczynski-nvidia Dec 16, 2025
d1d894e
remove aalcr from EXCLUDED_DATASETS in test_eval
anowaczynski-nvidia Dec 16, 2025
338de8b
Merge branch 'main' into anowaczynski/aalcr-fix
gwarmstrong Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nemo_skills/dataset/aalcr/prepare.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ def write_data_to_file(output_file, data, txt_file_folder, max_context_window, t
continue

if n_tokens != entry["input_tokens"]: # check if the n_tokens exactly match the input_tokens in the entry
raise ValueError(f"n_tokens: {n_tokens} != input_tokens: {entry['input_tokens']}")
LOG.warning(f"n_tokens: {n_tokens} != input_tokens: {entry['input_tokens']}")

entry[f"n_tokens_{tokenizer_name}"] = n_tokens
entry["question"] = question
Expand Down
1 change: 0 additions & 1 deletion tests/gpu-tests/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@
"mbpp",
"mmau-pro",
"asr-leaderboard",
"aalcr", # Has tokenization mismatch issues
"mrcr",
"audiobench",
"librispeech-pc",
Expand Down