SWE-bench: don't pass external environment variables into Apptainer containers#1116
Merged
gwarmstrong merged 1 commit intomainfrom Dec 16, 2025
Merged
SWE-bench: don't pass external environment variables into Apptainer containers#1116gwarmstrong merged 1 commit intomainfrom
gwarmstrong merged 1 commit intomainfrom
Conversation
Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
Contributor
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
gwarmstrong
approved these changes
Dec 16, 2025
wasiahmad
pushed a commit
that referenced
this pull request
Dec 19, 2025
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
wasiahmad
pushed a commit
that referenced
this pull request
Dec 19, 2025
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com> Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
hsiehjackson
pushed a commit
that referenced
this pull request
Jan 13, 2026
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com> Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
wasiahmad
pushed a commit
that referenced
this pull request
Feb 4, 2026
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Mar 18, 2026
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com>
dgtm777
pushed a commit
that referenced
this pull request
Mar 18, 2026
…ontainers (#1116) Signed-off-by: Nikolai Ludwig <nliudvig@nvidia.com> Signed-off-by: dgitman <dgitman@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR, environment variables from the Nemo-Skills container are no longer passed through to the Apptainer containers. This was a security risk, as this gave the agent access to potentially sensitive info.
If an environment variable does need to be passed into the Apptainer containers, one can use the
APPTAINERENV_prefix. For example, setting an environment variable in the cluster config asAPPTAINERENV_KEY=valuewill make it available inside of Apptainer asKEY=value. See the Apptainer docs for more info.The Slurm SWE-bench tests pass.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.