Skip to content

MAINT pin nemo-evaluator#1095

Merged
gwarmstrong merged 1 commit intomainfrom
georgea/pin-nemo-evaluator
Dec 10, 2025
Merged

MAINT pin nemo-evaluator#1095
gwarmstrong merged 1 commit intomainfrom
georgea/pin-nemo-evaluator

Conversation

@gwarmstrong
Copy link
Collaborator

@gwarmstrong gwarmstrong commented Dec 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated dependency version constraints for improved stability.

✏️ Tip: You can customize this high-level summary in your review settings.

Signed-off-by: George Armstrong <georgea@nvidia.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 10, 2025

📝 Walkthrough

Walkthrough

A version upper bound constraint was added to the nemo-evaluator-launcher dependency in requirements/main.txt. The dependency was previously unpinned and is now restricted to versions below 0.1.47.

Changes

Cohort / File(s) Change Summary
Dependency version constraint
requirements/main.txt
Updated nemo-evaluator-launcher from unpinned to bounded version spec <0.1.47

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

  • Verify that the version upper bound does not conflict with other direct or transitive dependencies
  • Confirm that the constraint aligns with any documented compatibility or upgrade requirements for this specific version threshold

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'MAINT pin nemo-evaluator' clearly and concisely describes the main change: pinning the nemo-evaluator dependency to a bounded version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch georgea/pin-nemo-evaluator

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
requirements/main.txt (1)

36-36: Add explanatory comment for the version constraint.

The constraint on nemo-evaluator-launcher lacks context. Following the established pattern in this file (see lines 16–17, 33), add a comment explaining why versions ≥0.1.47 are incompatible.

Apply this diff:

-nemo-evaluator-launcher<0.1.47
+nemo-evaluator-launcher<0.1.47  # [Reason for upper bound—e.g., breaking changes in 0.1.47]

Please verify that 0.1.47 is the correct upper bound and provide context for this constraint so maintainers understand its purpose.

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 774cef6 and 80c865e.

📒 Files selected for processing (1)
  • requirements/main.txt (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: pre-commit
  • GitHub Check: unit-tests

@gwarmstrong gwarmstrong merged commit 42fad05 into main Dec 10, 2025
5 checks passed
@gwarmstrong gwarmstrong deleted the georgea/pin-nemo-evaluator branch December 10, 2025 19:40
Jorjeous pushed a commit that referenced this pull request Dec 11, 2025
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
gwarmstrong added a commit that referenced this pull request Dec 11, 2025
Signed-off-by: George Armstrong <georgea@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Dec 12, 2025
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
wasiahmad pushed a commit that referenced this pull request Dec 19, 2025
Signed-off-by: George Armstrong <georgea@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Dec 19, 2025
Signed-off-by: George Armstrong <georgea@nvidia.com>

Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
hsiehjackson pushed a commit that referenced this pull request Jan 13, 2026
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: Cheng-Ping Hsieh <chsieh@nvidia.com>
wasiahmad pushed a commit that referenced this pull request Feb 4, 2026
Signed-off-by: George Armstrong <georgea@nvidia.com>
dgtm777 pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: George Armstrong <georgea@nvidia.com>
dgtm777 pushed a commit that referenced this pull request Mar 18, 2026
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: dgitman <dgitman@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant