MAINT: Add audio requirements to vllm image#1081
Conversation
Signed-off-by: George Armstrong <georgea@nvidia.com>
📝 WalkthroughWalkthroughThis change introduces a custom Dockerfile that extends the official vllm/vllm-openai:v0.10.2 image with vllm[audio] dependencies. The application's container configuration is updated to use this custom image, with supporting documentation reflecting the additional dependency layer. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
dockerfiles/Dockerfile.vllm (1)
1-2: Optionally avoid pip cache to keep the image smallerThe install is fine as-is, but you can reduce image size a bit by disabling the pip cache in this layer:
-FROM vllm/vllm-openai:v0.10.2 -RUN pip install "vllm[audio]" +FROM vllm/vllm-openai:v0.10.2 +RUN pip install --no-cache-dir "vllm[audio]"Purely cosmetic, feel free to skip if image size isn’t a concern.
dockerfiles/README.md (1)
37-39: Consider referencingDockerfile.vllm/ build flow for clarityThe description is accurate, but you might make this section more actionable by explicitly pointing to the Dockerfile and/or a build example, e.g.:
We build from
dockerfiles/Dockerfile.vllm, which uses the officialvllm/vllm-openai:v0.10.2image and adds thevllm[audio]dependencies.This keeps it aligned with the earlier examples for other images.
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
dockerfiles/Dockerfile.vllm(1 hunks)dockerfiles/README.md(1 hunks)nemo_skills/__init__.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: pre-commit
- GitHub Check: unit-tests
🔇 Additional comments (1)
nemo_skills/__init__.py (1)
18-27: Mapping vllm to Dockerfile.vllm looks consistentPointing
"vllm"todockerfile:dockerfiles/Dockerfile.vllmmatches how other locally-built images are wired and keeps the audio-enabled image under source control. No issues from my side.
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: George Zelenfroind <gzelenfroind@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: wasiahmad <wasiahmad@ucla.edu>
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com>
Signed-off-by: George Armstrong <georgea@nvidia.com> Signed-off-by: dgitman <dgitman@nvidia.com>
Summary by CodeRabbit
Chores
Documentation
✏️ Tip: You can customize this high-level summary in your review settings.