Skip to content

FIX integration tests by escaping aalcr and adding judge args #1062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gwarmstrong merged 5 commits into from
Dec 2, 2025
Merged

FIX integration tests by escaping aalcr and adding judge args #1062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
47fa174
WIP try fixing integration tests
gwarmstrong Dec 1, 2025
dab46e0
Apply suggestions from code review
gwarmstrong Dec 2, 2025
9344b92
Update tests/gpu-tests/test_eval.py
gwarmstrong Dec 2, 2025
035c3e6
Merge branch 'main' into georgea/fix-integration-tests
gwarmstrong Dec 2, 2025
79ae6cd
Merge branch 'main' into georgea/fix-integration-tests
gwarmstrong Dec 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions nemo_skills/dataset/open-proof-corpus-judge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
DATASET_GROUP = "math"
METRICS_TYPE = "answer-judgement"
GENERATION_ARGS = "++prompt_config=judge/math-proof-judge ++generation_key=judgement"

# This is a judge-only dataset (judges proofs directly)
JUDGE_PIPELINE_ARGS = {}
3 changes: 3 additions & 0 deletions nemo_skills/dataset/proof-arena-judge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
DATASET_GROUP = "math"
METRICS_TYPE = "answer-judgement"
GENERATION_ARGS = "++prompt_config=judge/math-proof-judge ++generation_key=judgement"

# This is a judge-only dataset (judges proofs directly)
JUDGE_PIPELINE_ARGS = {}
3 changes: 3 additions & 0 deletions nemo_skills/dataset/proof-bench-judge/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,6 @@
DATASET_GROUP = "math"
METRICS_TYPE = "answer-judgement"
GENERATION_ARGS = "++prompt_config=judge/math-proof-judge ++generation_key=judgement"

# This is a judge-only dataset (judges proofs directly)
JUDGE_PIPELINE_ARGS = {}
5 changes: 4 additions & 1 deletion tests/gpu-tests/test_eval.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,12 +233,14 @@ def test_prepare_and_eval_all_datasets():
"ioi24",
"ioi25",
"bfcl_v3",
"bfcl_v4",
"swe-bench",
"aai",
"human-eval",
"human-eval-infilling",
"mbpp",
"mmau-pro",
"aalcr", # Has tokenization mismatch issues
}

dataset_names = sorted(
Expand All @@ -252,7 +254,8 @@ def test_prepare_and_eval_all_datasets():
judge_datasets = []
for dataset in dataset_names:
dataset_module = import_module(f"nemo_skills.dataset.{dataset}")
if getattr(dataset_module, "JUDGE_PIPELINE_ARGS", None):
# Check if JUDGE_PIPELINE_ARGS exists (even if empty dict, which is falsy)
if hasattr(dataset_module, "JUDGE_PIPELINE_ARGS"):
judge_datasets.append(dataset)

non_judge_datasets = [dataset for dataset in dataset_names if dataset not in judge_datasets]
Expand Down