Skip to content

feat(pii): add v3 replace_pii config and tabular replacer #672

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nina-xu wants to merge 15 commits into from
Closed

feat(pii): add v3 replace_pii config and tabular replacer #672

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
591c349
PII replacer v3 with alternative config shape and package layout.
nina-xu Aug 11, 2026
79f0a8b
fix formatting in test_parameters.py
nina-xu Aug 11, 2026
c2b2fc4
less unnecessary diffs
nina-xu Aug 11, 2026
996970a
remove unnecessary diffs
nina-xu Aug 11, 2026
e5ade21
mostly simplification & comments for readability
nina-xu Aug 11, 2026
41fda6d
more readability changes
nina-xu Aug 11, 2026
c8c21bd
match column names against all entity regexes and warn about collisions
nina-xu Aug 11, 2026
29063ef
have regex match across entity ane demo
nina-xu Aug 11, 2026
fecc2be
minor fixes
nina-xu Aug 12, 2026
97cc468
more clean ups
nina-xu Aug 12, 2026
30dc1fb
fix two bugs + further clean up with entity handlers
nina-xu Aug 12, 2026
f49b851
fix demo matching
nina-xu Aug 12, 2026
3b54314
use stats in discovery + reorgaznie tests
nina-xu Aug 12, 2026
19a427c
drop some Protocols and split the LLM seam into two
nina-xu Aug 14, 2026
4d97099
rename the config
nina-xu Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 23 additions & 5 deletions .github/workflows/config/.secrets.baseline
View file
Open in desktop

@kendrickb-nvidia kendrickb-nvidia Aug 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: Why is this diff here? Maybe an incorrect merge conflict resolution? Looks like possibly some other unexpected changes like pyproject.toml that are effectively reverting PRs from main.

If we do need to make changes to this secrets config, can we do it in a totally separate PR that just merges directly to main, and is not part of the feature branch changes?

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion .markdownlint.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
{
"MD013": false,
"MD034": false
"MD034": false,
"MD046": { "style": "fenced" }
}
2 changes: 1 addition & 1 deletion AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ Source code lives in `src/nemo_safe_synthesizer/`:
| `generation/` | GeneratorBackend, VllmBackend, regex manager, batch gen |
| `holdout/` | Train/test splitting |
| `llm/` | Model loading, metadata, memory management |
| `pii_replacer/` | NER-based PII detection and replacement |
| `pii_replacer/` | Heuristic tabular PII discovery and persona replacement |
| `privacy/` | DP transformers (Opacus integration) |
| `sdk/` | SafeSynthesizer builder, library_builder |
| `training/` | TrainingBackend, HuggingFace backend, timeseries_preprocessing (`timeseries_preprocessing.py`) |
Expand Down
2 changes: 0 additions & 2 deletions STYLE_GUIDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,6 @@ def is_json_object(value: object) -> TypeIs[dict[str, JsonValue]]:
)
```

Legacy modules (`pii_replacer/`) still use `Optional`/`List`/`Dict`. Only `pii_replacer/` is excluded from `ty` type-checking (see `[tool.ty.src] exclude` in `pyproject.toml`). The remaining legacy usages will be migrated when those modules come under the type checker.

### Control flow

- Prefer `match`/`case` for dispatch on types or tagged values. Not a blanket rule -- `if`/`elif` is fine for simple boolean predicates.
Expand Down
4 changes: 2 additions & 2 deletions design.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,7 @@ results = synthesizer.results

### PII Protection

- Named Entity Recognition (NER) to detect PII
- Heuristic discovery to find PII columns (names, values, dtypes)
- Deterministic replacement with synthetic values
- Preserves column statistics and distributions

Expand Down Expand Up @@ -469,7 +469,7 @@ safe-synthesizer-artifacts/
2. Custom Generation Backend: Implement `GeneratorBackend` abstract class
3. Custom Evaluation Component: Extend `Component` base class
4. Custom Data Actions: Add to `data_processing/actions/`
5. Custom PII Detectors: Extend NER pipeline
5. Custom PII discovery: extend heuristic detectors in `pii_replacer/`

---

Expand Down
2 changes: 1 addition & 1 deletion docs/developer-guide/architecture.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,4 +395,4 @@ The execution follows a clear pipeline: Data --> PII Replacement --> Training --
2. Custom Generation Backend: implement `GeneratorBackend` abstract class
3. Custom Evaluation Component: extend `Component` base class
4. Custom Data Actions: add to `data_processing/actions/`
5. Custom PII Detectors: extend NER pipeline
5. Custom PII discovery: extend heuristic detectors in `pii_replacer/`
Loading
Loading