Skip to content

chore(config): resume config handling - #550

Closed
binaryaaron wants to merge 4 commits into
mainfrom
binaryaaron/xgrammar-base/improve-resume-config-handling
Closed

chore(config): resume config handling#550
binaryaaron wants to merge 4 commits into
mainfrom
binaryaaron/xgrammar-base/improve-resume-config-handling

Conversation

@binaryaaron

Copy link
Copy Markdown
Collaborator
  • fix: upgrade xgrammar and use new structured gen method
  • chore: address cr
  • chore: last bits
  • fix: update config overrides for generate only runs

mckornfield and others added 4 commits June 2, 2026 21:03
Signed-off-by: mkornfield <mkornfield@nvidia.com>
Signed-off-by: mkornfield <mkornfield@nvidia.com>
Signed-off-by: mkornfield <mkornfield@nvidia.com>
Signed-off-by: Aaron Gonzales <aagonzales@nvidia.com>
@coderabbitai

coderabbitai Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 5acb5295-0abc-4dab-a940-f17324982971

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch binaryaaron/xgrammar-base/improve-resume-config-handling

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov

codecov Bot commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.71605% with 56 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...s/benchmarks/test_generation_structured_methods.py 49.09% 56 Missing ⚠️

📢 Thoughts on this report? Let us know!

@binaryaaron

Copy link
Copy Markdown
Collaborator Author

closing in favor of #549

@binaryaaron binaryaaron closed this Jun 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants