Skip to content

chore: fix artifact upload for coverage - #491

Merged
mckornfield merged 1 commit into
mainfrom
fix-upload-art/mck
May 13, 2026
Merged

chore: fix artifact upload for coverage#491
mckornfield merged 1 commit into
mainfrom
fix-upload-art/mck

Conversation

@mckornfield

@mckornfield mckornfield commented May 13, 2026

Copy link
Copy Markdown
Collaborator
  • fixes an issue blocking CI

Summary by CodeRabbit

  • Chores
    • Optimized CI/CD workflow to streamline coverage report uploads, ensuring efficiency across different build environments.

Review Change Stack

Signed-off-by: mkornfield <mkornfield@nvidia.com>
@mckornfield
mckornfield requested a review from a team as a code owner May 13, 2026 17:10
@coderabbitai

coderabbitai Bot commented May 13, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 392ad765-400f-4cdf-9d56-44204859bfaf

📥 Commits

Reviewing files that changed from the base of the PR and between cbf9104 and d158605.

📒 Files selected for processing (1)
  • .github/workflows/ci-checks.yml
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
  • GitHub Check: Unit Tests (3.11)
  • GitHub Check: Unit Tests (3.12)
  • GitHub Check: Unit Tests (3.13)
  • GitHub Check: Typecheck
  • GitHub Check: Analyze (Python)
  • GitHub Check: Analyze (python)
  • GitHub Check: Analyze (javascript-typescript)
🧰 Additional context used
📓 Path-based instructions (2)
.github/workflows/*.{yaml,yml}

📄 CodeRabbit inference engine (STYLE_GUIDE.md)

Use # with dashes for section dividers in GitHub Actions workflows.

Files:

  • .github/workflows/ci-checks.yml
.github/**

⚙️ CodeRabbit configuration file

Review GitHub configuration for branch protection expectations, CODEOWNERS alignment, least privilege permissions, pinned actions where practical, and consistency with CONTRIBUTING.md.

Files:

  • .github/workflows/ci-checks.yml
🔇 Additional comments (1)
.github/workflows/ci-checks.yml (1)

152-167: LGTM!


Walkthrough

The CI workflow's unit-test job now conditionally executes the "Upload coverage report" step only when the Python matrix version is 3.11, preventing duplicate coverage artifact uploads across multiple Python versions.

Changes

CI Coverage Upload

Layer / File(s) Summary
Coverage upload step condition
.github/workflows/ci-checks.yml
The "Upload coverage report" step is gated with a condition to execute only when matrix.python-version == '3.11'.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

ci

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: fix artifact upload for coverage' directly and accurately describes the main change: conditionally running the coverage upload step only for Python 3.11.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-upload-art/mck

Comment @coderabbitai help to get the list of available commands and usage tips.

@mckornfield
mckornfield merged commit d2da52e into main May 13, 2026
20 checks passed
@mckornfield
mckornfield deleted the fix-upload-art/mck branch May 13, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants