Skip to content

[dont merge] visualizing diff during rebase of mbridge#996

Closed
terrykong wants to merge 3 commits intomainfrom
yuya/adapt_megatron_bridge-rebase
Closed

[dont merge] visualizing diff during rebase of mbridge#996
terrykong wants to merge 3 commits intomainfrom
yuya/adapt_megatron_bridge-rebase

Conversation

@terrykong
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@terrykong terrykong changed the title [dont merge] [dont merge] visualizing diff during rebase of mbridge Aug 27, 2025
@terrykong terrykong force-pushed the yuya/adapt_megatron_bridge-rebase branch from 1af5241 to 16a45ce Compare August 27, 2025 05:09
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong force-pushed the yuya/adapt_megatron_bridge-rebase branch from 16a45ce to 0879596 Compare August 27, 2025 05:25
@github-actions
Copy link

✅ Submodule Fast-Forward Check Results

Check based on commit: 0879596 (PR #996 from yuya/adapt_megatron_bridge-rebase)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ New submodule being added
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

Signed-off-by: Terry Kong <terryk@nvidia.com>
@github-actions
Copy link

✅ Submodule Fast-Forward Check Results

Check based on commit: 092fb24 (PR #996 from yuya/adapt_megatron_bridge-rebase)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ New submodule being added
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@github-actions
Copy link

✅ Submodule Fast-Forward Check Results

Check based on commit: 1c9e78a (PR #996 from yuya/adapt_megatron_bridge-rebase)

✅ Submodules that are properly updated:

Megatron-Bridge: ✅ New submodule being added
Megatron-LM: ✅ PR branch is ahead of main branch (fast-forward)

All submodule changes look good! ✨

@terrykong
Copy link
Collaborator Author

opened a PR to update upstream branch: NVIDIA-NeMo/Megatron-Bridge#496

will test this branch, if it looks good i'll force push to #905

@terrykong
Copy link
Collaborator Author

closing. this branch has served it's purposes and i've forced pushed against the orig branch

@terrykong terrykong closed this Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant