Skip to content

test: introduce "run_first" marker to fail on config changes early#993

Merged
terrykong merged 2 commits intomainfrom
tk/test-qol
Aug 27, 2025
Merged

test: introduce "run_first" marker to fail on config changes early#993
terrykong merged 2 commits intomainfrom
tk/test-qol

Conversation

@terrykong
Copy link
Collaborator

What does this PR do ?

Add a marker called run_first to force some tests that fail often first. This includes config and recipe tests.

Also at the same time fix up #863

Issues

List issues that this PR closes (syntax):

Closes #863

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong requested a review from chtruong814 August 27, 2025 02:21
@github-actions
Copy link

ℹ️ File Consistency Check

Check based on commit: d0576b2 (PR #993 from tk/test-qol)

✅ DTensor Policy Worker Synchronization Check

Both DTensor policy worker files were modified in this PR:

  • nemo_rl/models/policy/dtensor_policy_worker.py
  • nemo_rl/models/policy/dtensor_policy_worker_v2.py

Please ensure that the changes are consistent between both files where applicable.


This check ensures that related file implementations remain synchronized across the codebase. If you believe this warning is incorrect or the files should intentionally differ, please add a comment explaining the reasoning.

@terrykong terrykong changed the title Tk/test qol test: introduce "run_first" marker to fail on config changes early Aug 27, 2025
@terrykong terrykong enabled auto-merge August 27, 2025 02:22
@terrykong terrykong added this pull request to the merge queue Aug 27, 2025
Merged via the queue into main with commit 8e0daa5 Aug 27, 2025
21 of 23 checks passed
@terrykong terrykong deleted the tk/test-qol branch August 27, 2025 06:15
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 28, 2025
…VIDIA-NeMo#993)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection pushed a commit to skirdey-inflection/RL that referenced this pull request Aug 30, 2025
…VIDIA-NeMo#993)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Sep 4, 2025
…VIDIA-NeMo#993)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Chore] Clean up config defaults throughout codebase

2 participants