Skip to content

fix: ulimit set in ray.sub#989

Merged
terrykong merged 1 commit intoNVIDIA-NeMo:mainfrom
bogdansalyp:bogdan/fix/ulimit_for_raysub_limit
Aug 27, 2025
Merged

fix: ulimit set in ray.sub#989
terrykong merged 1 commit intoNVIDIA-NeMo:mainfrom
bogdansalyp:bogdan/fix/ulimit_for_raysub_limit

Conversation

@bogdansalyp
Copy link
Contributor

@bogdansalyp bogdansalyp commented Aug 26, 2025

What does this PR do ?

Fixes a crash on a cluster with low ulimit

Issues

Closes #988

Usage

No changes to regular flow

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
@bogdansalyp bogdansalyp mentioned this pull request Aug 26, 2025
4 tasks
@bogdansalyp bogdansalyp marked this pull request as draft August 26, 2025 17:31
@bogdansalyp bogdansalyp marked this pull request as ready for review August 26, 2025 17:35
@bogdansalyp
Copy link
Contributor Author

@terrykong also do you know if that's a deliberate decision to have ray.sub -rw-r--r-- ? I'd make it chmod +x

@terrykong
Copy link
Collaborator

thanks for the fix @bogdansalyp

not deliberate, but is there a reason you want it to be executable? most of the sbatch args have to be provided based on diff users cluster env so the obvious saving is you don't need to specify sbatch if you put it in the #! header.

@bogdansalyp
Copy link
Contributor Author

@terrykong makes sense, I've just tried some automation but realized there's an easier way to solve what I'm looking for
so chmod +x isn't important at the moment, but the ulimit thing is
pls approve if everything's fine with it

@terrykong terrykong enabled auto-merge August 27, 2025 06:47
Copy link
Collaborator

@terrykong terrykong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested internally. lgtm. thanks for making nemo-rl better!

@terrykong terrykong added this pull request to the merge queue Aug 27, 2025
Merged via the queue into NVIDIA-NeMo:main with commit d168de3 Aug 27, 2025
35 checks passed
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 28, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection pushed a commit to skirdey-inflection/RL that referenced this pull request Aug 30, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Sep 4, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on a cluster with low ulimit

3 participants