Merged
Conversation
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
Contributor
Author
|
@terrykong also do you know if that's a deliberate decision to have ray.sub |
Collaborator
|
thanks for the fix @bogdansalyp not deliberate, but is there a reason you want it to be executable? most of the |
Contributor
Author
|
@terrykong makes sense, I've just tried some automation but realized there's an easier way to solve what I'm looking for |
terrykong
approved these changes
Aug 27, 2025
Collaborator
terrykong
left a comment
There was a problem hiding this comment.
tested internally. lgtm. thanks for making nemo-rl better!
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
skirdey-inflection
pushed a commit
to skirdey-inflection/RL
that referenced
this pull request
Aug 30, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com> Signed-off-by: Stanislav Kirdey <stan@inflection.ai>
soodoshll
pushed a commit
to soodoshll/RL
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Bogdan Salyp <bogdansalyp@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes a crash on a cluster with low
ulimitIssues
Closes #988
Usage
No changes to regular flow
Before your PR is "Ready for review"
Pre checks:
Additional Information