fix: address double bos in eval task #962
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-97
reviewed
Aug 22, 2025
Contributor
yuki-97
left a comment
yuki-97
left a comment
There was a problem hiding this comment.
LGTM, thanks for the fix!
yuki-97
approved these changes
Aug 23, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 28, 2025
Signed-off-by: Zhiyu Li <[email protected]> Signed-off-by: Zhiyu Li <[email protected]> Co-authored-by: Yuki Huang <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/address_double_bos
branch
from
2c0c4f0 to
68043c9
Compare
Signed-off-by: Zhiyu Li <[email protected]>
Co-authored-by: Yuki Huang <[email protected]> Signed-off-by: Zhiyu Li <[email protected]>
ZhiyuLi-Nvidia
force-pushed
the
zhiyul/address_double_bos
branch
from
68043c9 to
19670db
Compare
terrykong
approved these changes
Sep 2, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
wangshangsam
pushed a commit
that referenced
this pull request
Sep 4, 2025
Signed-off-by: Zhiyu Li <[email protected]> Signed-off-by: Zhiyu Li <[email protected]> Co-authored-by: Yuki Huang <[email protected]> Signed-off-by: Shang Wang <[email protected]>
terrykong
pushed a commit
that referenced
this pull request
Sep 6, 2025
Signed-off-by: Zhiyu Li <[email protected]> Signed-off-by: Zhiyu Li <[email protected]> Co-authored-by: Yuki Huang <[email protected]>
guyueh1
pushed a commit
to guyueh1/NeMo-RL
that referenced
this pull request
Sep 15, 2025
Signed-off-by: Zhiyu Li <[email protected]> Signed-off-by: Zhiyu Li <[email protected]> Co-authored-by: Yuki Huang <[email protected]>
PrinsYin
pushed a commit
to PrinsYin/RL
that referenced
this pull request
Nov 30, 2025
Signed-off-by: Zhiyu Li <[email protected]> Signed-off-by: Zhiyu Li <[email protected]> Co-authored-by: Yuki Huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
As titled, address double bos issue all over the repo. The missing part is mainly in eval.
#855
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information