Skip to content

feat: adding the megatron-bridge submodules and fix up dependencies#920

Merged
terrykong merged 5 commits intoyuya/adapt_megatron_bridgefrom
tk/yuya/adapt_megatron_bridge
Aug 14, 2025
Merged

feat: adding the megatron-bridge submodules and fix up dependencies#920
terrykong merged 5 commits intoyuya/adapt_megatron_bridgefrom
tk/yuya/adapt_megatron_bridge

Conversation

@terrykong
Copy link
Collaborator

@terrykong terrykong commented Aug 13, 2025 •
edited
Loading

(related #905)

Validated with:

uv run --extra mcore python tests/functional/test_converter_roundtrip.py
uv run --extra mcore python tools/refit_verifier.py --model_name meta-llama/Llama-3.2-1B
uv run --extra mcore python examples/run_grpo_math.py --config examples/configs/grpo_math_1B_megatron.yaml \
 ️       policy.megatron_cfg.distributed_data_parallel_config.overlap_grad_reduce=False \
        policy.megatron_cfg.distributed_data_parallel_config.overlap_param_gather=False

@terrykong terrykong changed the title Tk/yuya/adapt megatron bridge feat: adding the megatron-bridge submodules and fix up dependencies Aug 14, 2025
terrykong and others added 5 commits August 14, 2025 05:42
@terrykong
Add Megatron-Bridge as submodule on yuya/nemo-rl-use; remove NeMo sub…
73b96c9 
…module; update pyproject and workspace

Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
wip
a6c2a0b 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
nemo-run
46e73ff 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong
fix
87284fe 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@yaoyu-33 @terrykong
fix hooks
6071bab 
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong force-pushed the tk/yuya/adapt_megatron_bridge branch from dcc1ef0 to 6071bab Compare August 14, 2025 05:42
@terrykong terrykong requested review from parthchadha and yaoyu-33 and removed request for parthchadha August 14, 2025 05:43
@terrykong terrykong marked this pull request as ready for review August 14, 2025 17:45
@terrykong terrykong merged commit af50fd3 into yuya/adapt_megatron_bridge Aug 14, 2025
4 of 5 checks passed
@terrykong terrykong deleted the tk/yuya/adapt_megatron_bridge branch August 14, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yaoyu-33 yaoyu-33 yaoyu-33 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@terrykong @yaoyu-33