Skip to content

test: lower step count on gemma nightly test to finish within 4 hours #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 2 commits into from
Aug 12, 2025
Merged

test: lower step count on gemma nightly test to finish within 4 hours #880

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8de6bf5
tests: lower step count on gemma nightly test to finish within 4 hours
terrykong Aug 11, 2025
6ee857a
revert submodule
terrykong Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_suites/llm/grpo-gemma3-1b-it-1n8g-fsdp2tp1.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ source $SCRIPT_DIR/common.env

# ===== BEGIN CONFIG =====
NUM_NODES=1
STEPS_PER_RUN=500
MAX_STEPS=500
STEPS_PER_RUN=400
MAX_STEPS=400
NUM_RUNS=$(( (MAX_STEPS + STEPS_PER_RUN - 1) / STEPS_PER_RUN )) # Round up
NUM_MINUTES=120
# ===== END CONFIG =====
Expand Down Expand Up @@ -35,5 +35,5 @@ uv run tests/json_dump_tb_logs.py $LOG_DIR --output_path $JSON_METRICS
if [[ $(jq 'to_entries | .[] | select(.key == "train/loss") | .value | keys | map(tonumber) | max' $JSON_METRICS) -ge $MAX_STEPS ]]; then
uv run tests/check_metrics.py $JSON_METRICS \
'mean(data["train/token_mult_prob_error"]) < 1.1' \
'data["train/token_mult_prob_error"]["500"] < 1.1'
"data[\"train/token_mult_prob_error\"][\"${MAX_STEPS}\"] < 1.1"
fi
Loading