fix: Remove reference of tokenizer from generation backend (#75)#82
Merged
parthchadha merged 4 commits intomainfrom Mar 26, 2025
Merged
fix: Remove reference of tokenizer from generation backend (#75)#82parthchadha merged 4 commits intomainfrom
parthchadha merged 4 commits intomainfrom
Conversation
github-actions
bot
added
the
documentation
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
parthchadha
force-pushed
the
pchadha/remove-tokenizer-generation
branch
from
24fcaad to
fbc3bdf
Compare
parthchadha
changed the title
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
terrykong
reviewed
Mar 25, 2025
terrykong
previously approved these changes
Mar 25, 2025
parthchadha
force-pushed
the
pchadha/remove-tokenizer-generation
branch
from
f8eba95 to
521e79a
Compare
SahilJain314
previously approved these changes
Mar 25, 2025
terrykong
previously approved these changes
Mar 25, 2025
Signed-off-by: Parth Chadha <pchadha@nvidia.com>
parthchadha
dismissed stale reviews from terrykong and SahilJain314
via
1651311
parthchadha
force-pushed
the
pchadha/remove-tokenizer-generation
branch
from
521e79a to
1651311
Compare
SahilJain314
approved these changes
Mar 26, 2025
yfw
pushed a commit
that referenced
this pull request
Apr 2, 2025
KiddoZhu
pushed a commit
that referenced
this pull request
May 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Remove reference of tokenizer from generation backend
Issues
#75
Usage
N/A
Before your PR is "Ready for review"
Pre checks:
Additional Information