feat(logger.py): support swanlab#716
Conversation
|
@terrykong When I run ray cluster
download some models
|
|
@tpoisonooo can you try these instructions: https://docs.nvidia.com/nemo/rl/latest/testing.html#unit-tests So to just test the logger, i'd run: You may also run bare pytest, but we've had some issues where pytest was sensitive to the current working directory, so we have this script that can be run more robustly for convenience. |
|
I think you do actually need HF access to those models @terrykong, the unit tests use them (fwiw, I've been able to run bare pytest in the past so long as I have the HF key). Maybe we should switch fully to qwen models in the tests to make it easier for community members to run locally? @tpoisonooo I'd recommend doing a hf login with a key that has access to the repo (it's easy to get access) |
|
@tpoisonooo Sorry you're running into this. I didn't realize they actually rejected anyone... I'll PR something today that'll filter out the gated repos so you can at least run the tests that don't require those models. |
|
@tpoisonooo Updating here, PR #755 is merged. You should be able to run tests without HF with this. |
e51fe34 to
ec98ae4
Compare
@SahilJain314 @terrykong unittest passed. |
terrykong
left a comment
There was a problem hiding this comment.
awesome work @tpoisonooo ! thanks for adding support, i've left some comments
done. |
Signed-off-by: KiddoZhu <zhaochengz@nvidia.com> Signed-off-by: Terry Kong <terryk@nvidia.com> Co-authored-by: Terry Kong <terryk@nvidia.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: Xuehan <xxman@google.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
Signed-off-by: Zhiyu Li <zhiyul@NVIDIA.com> Signed-off-by: Zhiyu Li <zhiyul@nvidia.com> Signed-off-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: Yuki Huang <yukih@nvidia.com> Co-authored-by: yuki <48991475+yuki-666@users.noreply.github.com> Signed-off-by: tpoisonooo <khj.application@aliyun.com>
|
@terrykong lint error fixed. |
terrykong
left a comment
There was a problem hiding this comment.
great work! thanks for the contribution!
|
@tpoisonooo looks like the linter failed. can you run it through pre-commit and make sure everything passes and we can try again? |
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
For this PRok, I have installed
For code lintI have seen a better practice: github actions bot merge format-code to human PR. Here is an example: Tencent/ncnn@a2e23d9 in Tencent/ncnn#4782 |
Signed-off-by: tpoisonooo <khj.application@aliyun.com>
|
@tpoisonooo could you install pre-commit hooks like this? if it doesn't work for you, i will help shepherd this PR in |
My mistake, Since I only changed 2 .py files and already manully fixed the lint error, nothing can be committed, please retry the CI. @terrykong |
|
finally.. the CI passed.. QvQ |
It seems not to have passed the Docs-Test QAQ, https://github.com/NVIDIA-NeMo/RL/actions/runs/16798324457/job/47576893936 |
This looks like some errors in CI https://github.com/NVIDIA-NeMo/RL/actions/runs/16798324457/job/47576893936
|
|
hey @tpoisonooo . I'll take a look at this later today and help you get your PR in (i'll make sure to credit you for the contribution) |
|
closing since this is replaced with #923 |






What does this PR do ?
Same as #691 ,
wandbis unreachable for our district, addswanlabby instead. Just like github --> giteeIssues
List issues that this PR closes (syntax):
No
Usage
Here is my example config:
Here is swanlab UI and public project
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information