test: Add Megatron tests by ashors1 · Pull Request #713 · NVIDIA-NeMo/RL

ashors1 · 2025-07-22T21:52:22Z

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

adds Megatron tests for GRPO
updates SFT tests to use OpenMathInstruct
Adds functional SFT and DPO Megatron tests
+ some other minor improvements to existing tests

Issues

List issues that this PR closes (syntax):

Usage

You can potentially add a usage example below

# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

Make sure you read and followed Contributor guidelines
Did you write any new necessary tests?
Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

...

Signed-off-by: ashors1 <ashors@nvidia.com>

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Stanislav Kirdey <stan@inflection.ai>

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>

ashors1 marked this pull request as ready for review July 30, 2025 17:25

ashors1 requested review from SahilJain314, terrykong and yfw July 30, 2025 17:32

terrykong approved these changes Aug 12, 2025

View reviewed changes

add Megatron tests, improve some existing tests

99d5847

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 force-pushed the ashors/mcore-tests branch from 4166f22 to 99d5847 Compare August 12, 2025 16:30

terrykong previously approved these changes Aug 12, 2025

View reviewed changes

terrykong enabled auto-merge August 12, 2025 16:31

terrykong added this pull request to the merge queue Aug 12, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 12, 2025

rename unit test file to avoid name conflict

3fe2898

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via 3fe2898 August 12, 2025 21:56

terrykong enabled auto-merge August 12, 2025 22:18

terrykong previously approved these changes Aug 12, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 12, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025

rename tests

473f408

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via 473f408 August 13, 2025 17:35

terrykong enabled auto-merge August 13, 2025 17:44

terrykong approved these changes Aug 13, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Aug 13, 2025

Merge branch 'main' of github.com:NVIDIA/nemo-rl into ashors/mcore-tests

f163672

terrykong previously approved these changes Aug 13, 2025

View reviewed changes

terrykong enabled auto-merge August 13, 2025 17:50

terrykong added this pull request to the merge queue Aug 13, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2025

fix unit tests

23966de

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via 23966de August 14, 2025 16:03

terrykong previously approved these changes Aug 20, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 20, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2025

fix unit test

3032842

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via 3032842 August 20, 2025 18:56

terrykong enabled auto-merge August 20, 2025 19:47

terrykong previously approved these changes Aug 20, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 20, 2025

This was referenced Aug 21, 2025

fix: memory optimizations for Nemotron12B 12k seqlen DPO training #926

Merged

feat: support swanlab logger #923

Merged

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 21, 2025

fix empty env vars

fd723ea

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via fd723ea August 21, 2025 16:22

re-disable expandable segments for qwen30ba3b

31d832a

Signed-off-by: ashors1 <ashors@nvidia.com>

terrykong enabled auto-merge August 21, 2025 22:24

terrykong previously approved these changes Aug 21, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 21, 2025

github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 22, 2025

fix null env vars

84b460b

Signed-off-by: ashors1 <ashors@nvidia.com>

ashors1 dismissed terrykong’s stale review via 84b460b August 22, 2025 19:28

terrykong approved these changes Aug 22, 2025

View reviewed changes

terrykong added this pull request to the merge queue Aug 22, 2025

Merged via the queue into main with commit ac7469f Aug 23, 2025
19 checks passed

terrykong deleted the ashors/mcore-tests branch August 23, 2025 00:23

jveronvialard pushed a commit that referenced this pull request Aug 27, 2025

test: Add Megatron tests (#713)

d52b1a7

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Julien Veron Vialard <jveronvialar@nvidia.com>

soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 28, 2025

test: Add Megatron tests (NVIDIA-NeMo#713)

4deea53

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>

soodoshll pushed a commit to soodoshll/RL that referenced this pull request Sep 4, 2025

test: Add Megatron tests (NVIDIA-NeMo#713)

76c407a

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>

PrinsYin pushed a commit to PrinsYin/RL that referenced this pull request Nov 30, 2025

test: Add Megatron tests (NVIDIA-NeMo#713)

77f11b4

Signed-off-by: ashors1 <ashors@nvidia.com> Co-authored-by: Terry Kong <terrycurtiskong@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add Megatron tests#713

test: Add Megatron tests#713
terrykong merged 16 commits intomainfrom
ashors/mcore-tests

ashors1 commented Jul 22, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

ashors1 commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do ?

Issues

Usage

Before your PR is "Ready for review"

Additional Information

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ashors1 commented Jul 22, 2025 •

edited

Loading