Skip to content

ci: add a job that checks if submodules are fast forwarded#695

Merged
terrykong merged 15 commits intomainfrom
tk-ff-submodule-check
Jul 23, 2025
Merged

ci: add a job that checks if submodules are fast forwarded#695
terrykong merged 15 commits intomainfrom
tk-ff-submodule-check

Conversation

@terrykong
Copy link
Collaborator

@terrykong terrykong commented Jul 18, 2025

It's easy to overlook submodule changes so this introduces a job that checks if the submodule update can be fast-forwarded to. If it can't it could mean that the feature branch didn't incorporate commits on main.

Since it's possible someone would rebase, non-fast-forwarded shouldn't gate a PR, so this change just makes a comment on the PR to investigate to see if it's intentional

@github-actions github-actions bot added the CI Relating to CI label Jul 18, 2025
@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from github-actions bot Jul 21, 2025
@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from github-actions bot Jul 21, 2025
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 2f5a368 (PR #695 from tk-ff-submodule-check)

❌ Submodules that need attention:

NeMo: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/NeMo/commits/33259f2540af6eef375d43fc48bdcbd7ec490c29/
CURRENT (PR #695 from tk-ff-submodule-check): https://github.com/NVIDIA/NeMo/commits/30e6820dbd47cf46371c41a2e40cb2e9cef51f6b/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@NVIDIA-NeMo NVIDIA-NeMo deleted a comment from github-actions bot Jul 21, 2025
@github-actions
Copy link

❌ Submodule Fast-Forward Check Failed

Check based on commit: 2fdf229 (PR #695 from tk-ff-submodule-check)

❌ Submodules that need attention:

NeMo: ❌ Commits have DIVERGED from a common ancestor
TARGET (main branch): https://github.com/NVIDIA/NeMo/commits/33259f2540af6eef375d43fc48bdcbd7ec490c29/
CURRENT (PR #695 from tk-ff-submodule-check): https://github.com/NVIDIA/NeMo/commits/30e6820dbd47cf46371c41a2e40cb2e9cef51f6b/

Please ensure all submodule commits are fast-forwards of the main branch before merging.

@terrykong terrykong marked this pull request as ready for review July 21, 2025 21:59
@terrykong terrykong requested review from chtruong814 and ko3n1g July 22, 2025 05:34
terrykong added 15 commits July 22, 2025 23:45
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
This reverts commit f1e4d79.

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
@terrykong terrykong force-pushed the tk-ff-submodule-check branch from 4db3b99 to 396bfb8 Compare July 22, 2025 23:45
@terrykong terrykong requested a review from chtruong814 July 22, 2025 23:46
@terrykong terrykong enabled auto-merge July 22, 2025 23:46
@terrykong terrykong added this pull request to the merge queue Jul 22, 2025
Merged via the queue into main with commit 4d42bca Jul 23, 2025
15 of 16 checks passed
@terrykong terrykong deleted the tk-ff-submodule-check branch July 23, 2025 02:18
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
…Mo#695)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 28, 2025
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
rohitrango pushed a commit that referenced this pull request Jul 29, 2025
Signed-off-by: Terry Kong <terryk@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
…Mo#695)

Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Relating to CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants