ci: add a job that checks if submodules are fast forwarded#695
ci: add a job that checks if submodules are fast forwarded#695
Conversation
❌ Submodule Fast-Forward Check FailedCheck based on commit: 2f5a368 (PR #695 from ❌ Submodules that need attention:NeMo: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
❌ Submodule Fast-Forward Check FailedCheck based on commit: 2fdf229 (PR #695 from ❌ Submodules that need attention:NeMo: ❌ Commits have DIVERGED from a common ancestor Please ensure all submodule commits are fast-forwards of the main branch before merging. |
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
This reverts commit f1e4d79. Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
4db3b99 to
396bfb8
Compare
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Jialei Chen <jialeic@google.com>
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
Signed-off-by: Terry Kong <terryk@nvidia.com>
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com>
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com>
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com>
…Mo#695) Signed-off-by: Terry Kong <terryk@nvidia.com> Signed-off-by: Qidong Su <qidongs@nvidia.com>
It's easy to overlook submodule changes so this introduces a job that checks if the submodule update can be fast-forwarded to. If it can't it could mean that the feature branch didn't incorporate commits on
main.Since it's possible someone would rebase, non-fast-forwarded shouldn't gate a PR, so this change just makes a comment on the PR to investigate to see if it's intentional