Skip to content

fix: make mcore lr scheduler configuration consistent with dtensor#681

Merged
terrykong merged 5 commits intomainfrom
ashors/fix-mcore-lr-schedule
Jul 17, 2025
Merged

fix: make mcore lr scheduler configuration consistent with dtensor#681
terrykong merged 5 commits intomainfrom
ashors/fix-mcore-lr-schedule

Conversation

@ashors1
Copy link
Contributor

@ashors1 ashors1 commented Jul 16, 2025

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

ashors1 added 3 commits July 16, 2025 11:46
@ashors1
take one scheduler step per rollout batch
0fbc0b2 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
update configs
c0c7590 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1
remove unused variable
cae0933 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 added the r0.3.0 Release r0.3.0 label Jul 16, 2025
parthchadha
parthchadha previously approved these changes Jul 16, 2025
View reviewed changes
@ashors1 @parthchadha
Remove old comment
8310511 
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
parthchadha
parthchadha previously approved these changes Jul 16, 2025
View reviewed changes
terrykong
terrykong previously approved these changes Jul 16, 2025
View reviewed changes
@terrykong terrykong added this pull request to the merge queue Jul 16, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 17, 2025
@ashors1
increase learning rate for test
fd69656 
Signed-off-by: ashors1 <ashors@nvidia.com>
@ashors1 ashors1 dismissed stale reviews from terrykong and parthchadha via fd69656 July 17, 2025 03:27
@terrykong terrykong enabled auto-merge July 17, 2025 03:45
@terrykong terrykong added this pull request to the merge queue Jul 17, 2025
Merged via the queue into main with commit 2f8ed7a Jul 17, 2025
13 of 14 checks passed
@terrykong terrykong deleted the ashors/fix-mcore-lr-schedule branch July 17, 2025 05:57
github-merge-queue bot pushed a commit that referenced this pull request Jul 18, 2025
@ashors1
fix: fix lr scheduler for config that was missed in #681 (#693)
8921963 
Signed-off-by: ashors1 <ashors@nvidia.com>
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
@ashors1 @parthchadha @SahilJain314
fix: make mcore lr scheduler configuration consistent with dtensor (#681
68547c0 
)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
@ashors1 @SahilJain314
fix: fix lr scheduler for config that was missed in #681 (#693)
3804ecc 
Signed-off-by: ashors1 <ashors@nvidia.com>
ZhiyuLi-Nvidia pushed a commit that referenced this pull request Jul 21, 2025
@ashors1 @parthchadha @ZhiyuLi-Nvidia
fix: make mcore lr scheduler configuration consistent with dtensor (#681
d83461c 
)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Zhiyu Li <zhiyul@nvidia.com>
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
@ashors1 @parthchadha @SahilJain314
fix: make mcore lr scheduler configuration consistent with dtensor (#681
75e2f69 
)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
SahilJain314 pushed a commit that referenced this pull request Jul 21, 2025
@ashors1 @SahilJain314
fix: fix lr scheduler for config that was missed in #681 (#693)
df53dbc 
Signed-off-by: ashors1 <ashors@nvidia.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
@ashors1 @parthchadha @jialei777
fix: make mcore lr scheduler configuration consistent with dtensor (N…
c8115f9 
…VIDIA-NeMo#681)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
@ashors1 @jialei777
fix: fix lr scheduler for config that was missed in NVIDIA-NeMo#681 (N…
00e33a9 
…VIDIA-NeMo#693)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
@ashors1 @parthchadha @KiddoZhu
fix: make mcore lr scheduler configuration consistent with dtensor (#681
82e836f 
)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
@ashors1 @KiddoZhu
fix: fix lr scheduler for config that was missed in #681 (#693)
165b9e8 
Signed-off-by: ashors1 <ashors@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
@ashors1 @parthchadha @xxman-google
fix: make mcore lr scheduler configuration consistent with dtensor (N…
64dcde1 
…VIDIA-NeMo#681)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
xxman-google pushed a commit to xxman-google/NeMo-RL that referenced this pull request Jul 30, 2025
@ashors1 @xxman-google
fix: fix lr scheduler for config that was missed in NVIDIA-NeMo#681 (N…
08e4583 
…VIDIA-NeMo#693)

Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1 @parthchadha
fix: make mcore lr scheduler configuration consistent with dtensor (N…
aa66636 
…VIDIA-NeMo#681)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1
fix: fix lr scheduler for config that was missed in NVIDIA-NeMo#681 (N…
70cdeeb 
…VIDIA-NeMo#693)

Signed-off-by: ashors1 <ashors@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1 @parthchadha @xxman-google
fix: make mcore lr scheduler configuration consistent with dtensor (N…
df3625c 
…VIDIA-NeMo#681)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
@ashors1 @xxman-google
fix: fix lr scheduler for config that was missed in NVIDIA-NeMo#681 (N…
45ca63d 
…VIDIA-NeMo#693)

Signed-off-by: ashors1 <ashors@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@ashors1 @parthchadha @soodoshll
fix: make mcore lr scheduler configuration consistent with dtensor (N…
2071a90 
…VIDIA-NeMo#681)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Anna Shors <ashors@nvidia.com>
Co-authored-by: Parth Chadha <pchadha@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
soodoshll pushed a commit to soodoshll/RL that referenced this pull request Aug 13, 2025
@ashors1 @soodoshll
fix: fix lr scheduler for config that was missed in NVIDIA-NeMo#681 (N…
da9b87b 
…VIDIA-NeMo#693)

Signed-off-by: ashors1 <ashors@nvidia.com>
Signed-off-by: Qidong Su <qidongs@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terrykong terrykong terrykong approved these changes

@SahilJain314 SahilJain314 Awaiting requested review from SahilJain314

+1 more reviewer

@parthchadha parthchadha parthchadha left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

r0.3.0 Release r0.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ashors1 @terrykong @parthchadha