Skip to content

fix: Fix error message in VllmGenerationWorker. #633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Aug 7, 2025
Merged

fix: Fix error message in VllmGenerationWorker. #633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nemo_rl/models/generation/vllm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,8 @@ def _patch_vllm_init_workers_ray():
raise ImportError(
"vLLM is not installed. Please check that the py_executable in the runtime_env of VllmGenerationWorker "
"covers the vllm dependency. You may have to update nemo_rl/distributed/ray_actor_environment_registry.py. "
"If you are working interactively, you can install by running `uv sync --extra vllm` anywhere in the repo."
"This error can also happen if the venv creation was aborted or errored out in the middle. In that case, "
"please run at least once with the environment variable NRL_FORCE_REBUILD_VENVS=true set to force the rebuild of the environment."
)
vllm_kwargs: dict[str, Any] = copy.deepcopy(self.cfg.get("vllm_kwargs", {}))

Expand Down
3 changes: 2 additions & 1 deletion nemo_rl/models/generation/vllm_backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,8 @@
raise ImportError(
"vLLM is not installed. Please check that the py_executable in the runtime_env of VllmGenerationWorker "
"covers the vllm dependency. You may have to update nemo_rl/distributed/ray_actor_environment_registry.py. "
"If you are working interactively, you can install by running `uv sync --extra vllm` anywhere in the repo."
"This error can also happen if the venv creation was aborted or errored out in the middle. In that case, "
"please run at least once with the environment variable NRL_FORCE_REBUILD_VENVS=true set to force the rebuild of the environment."
)


Expand Down
Loading