-
Notifications
You must be signed in to change notification settings - Fork 211
feat: track policy training compute throughput #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 12 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
68b93cf
Implement FLOPs counter for DTensor policy worker
ybgao-nvidia feae724
Fix import
ybgao-nvidia 95439ee
Make linter happy
ybgao-nvidia 7a3591a
Make linter even happier
ybgao-nvidia ad3ebe3
Include MFU computation for training
ybgao-nvidia c23bcb0
use actual token count to compute FLOPs excluding padding
ybgao-nvidia 83e3344
removed incompatible models; get vocab size from config
ybgao-nvidia 3138e00
Move FLOPs tracker logic to lm_policy
ybgao-nvidia 463e308
added tests, flop formulas, megatron backend support, and optimized w…
ybgao-nvidia e71127f
Merge branch 'main' into main
ybgao-nvidia 52705de
make linter happy
ybgao-nvidia 5ed04c3
don't fail test when GPU flops information not available
ybgao-nvidia cad22b0
fix lint
ybgao-nvidia 8fc89de
don't fail megatron test when theoretical flops unavailable
ybgao-nvidia f9fb913
Merge branch 'main' into main
ybgao-nvidia File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.