Skip to content

enable mcore rope fusion#608

Merged
SahilJain314 merged 3 commits intomainfrom
jiemingz/rope_fusion
Jul 5, 2025
Merged

enable mcore rope fusion#608
SahilJain314 merged 3 commits intomainfrom
jiemingz/rope_fusion

Conversation

@jiemingz
Copy link
Contributor

@jiemingz jiemingz commented Jul 3, 2025

What does this PR do ?

image image image

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
@jiemingz jiemingz requested a review from terrykong July 4, 2025 13:53
terrykong
terrykong previously approved these changes Jul 4, 2025
@terrykong terrykong added this pull request to the merge queue Jul 4, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 4, 2025
@jiemingz jiemingz force-pushed the jiemingz/rope_fusion branch from 1317eea to 4746b01 Compare July 5, 2025 05:21
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
@jiemingz jiemingz force-pushed the jiemingz/rope_fusion branch from 4746b01 to 0f34192 Compare July 5, 2025 05:25
@SahilJain314 SahilJain314 enabled auto-merge July 5, 2025 09:13
@SahilJain314 SahilJain314 added this pull request to the merge queue Jul 5, 2025
Merged via the queue into main with commit 3cb5e44 Jul 5, 2025
11 of 14 checks passed
@SahilJain314 SahilJain314 deleted the jiemingz/rope_fusion branch July 5, 2025 11:23
therealnaveenkamal pushed a commit to therealnaveenkamal/RL that referenced this pull request Jul 7, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
jialei777 pushed a commit to jialei777/nemo-rl that referenced this pull request Jul 23, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Signed-off-by: Jialei Chen <jialeic@google.com>
KiddoZhu pushed a commit that referenced this pull request Jul 28, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
FannYYW pushed a commit to xxman-google/NeMo-RL that referenced this pull request Aug 5, 2025
Signed-off-by: Jimmy Zhang <jiemingz@nvidia.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants