Skip to content

fix: update gemma3 prefix #585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Jul 1, 2025
Merged

fix: update gemma3 prefix #585

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nemo_rl/models/dtensor/parallelize.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ def _parallelize_gemma3(
Tensor parallelism is not supported for Gemma3 models because of tied word embeddings.
"""
if isinstance(model, Gemma3ForConditionalGeneration):
model_prefix = "language_model.model"
model_prefix = "language_model"
else:
model_prefix = "model"

Expand Down Expand Up @@ -399,7 +399,7 @@ def _parallelize_model(
"""
model_cls = type(model)
if model_cls == Gemma3ForConditionalGeneration:
layers: torch.nn.ModuleList = model.language_model.model.layers # type: ignore
layers: torch.nn.ModuleList = model.language_model.layers # type: ignore
num_attention_heads = model.config.text_config.num_attention_heads
num_key_value_heads = model.config.text_config.num_key_value_heads
else:
Expand Down
Loading