Skip to content

fix: correct mcore dtype + assertion on activation_func #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terrykong merged 1 commit into from
Jun 28, 2025
Merged

fix: correct mcore dtype + assertion on activation_func #572

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions nemo_rl/models/policy/megatron_policy_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -459,15 +459,27 @@ def __init__(
)
model_cfg.bf16 = self.dtype == torch.bfloat16
model_cfg.fp16 = self.dtype == torch.float16
model_cfg.params_dtype = dtype_map[
self.cfg["megatron_cfg"]["optimizer"]["params_dtype"]
] # FP32 for amp
if model_cfg.fp16:
assert not model_cfg.bf16, "fp16 and bf16 cannot be used together"
model_cfg.params_dtype = torch.float16
elif model_cfg.bf16:
assert not model_cfg.fp16, "fp16 and bf16 cannot be used together"
model_cfg.params_dtype = torch.bfloat16
else:
model_cfg.params_dtype = torch.float32
model_cfg.pipeline_dtype = dtype_map[self.cfg["megatron_cfg"]["pipeline_dtype"]]
model_cfg.parallel_output = True
if self.cfg["megatron_cfg"]["activation_checkpointing"]:
model_cfg.activations_checkpoint_granularity = "full"
model_cfg.activations_checkpoint_method = "uniform"
model_cfg.activations_checkpoint_num_layers = 1
if not model_cfg.gated_linear_unit:
assert model_cfg.activation_func is not None, (
"activation_func must be set if not using gated_linear_unit. This likely "
"indicates an issue in configuration conversion (e.g. activation func was "
"a lambda and couldn't be serialized). This is based on this check "
"https://github.com/NVIDIA/Megatron-LM/blob/1ab876ddc4c1893c76f26d775226a8d1dcdfb3d2/megatron/core/transformer/mlp.py#L174."
)

checkpoint_config = CheckpointConfig(
save_interval=100,
Expand Down
Loading