-
Notifications
You must be signed in to change notification settings - Fork 452
feat: Reduce number of Cuda IPC in Refit #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
36a2d68
Pack tensor at megatron worker and unpack at vllm worker
guyueh1 4cfcd7b
Cleanup code
guyueh1 1fff128
use view instead of copy for unpacking
guyueh1 7dafae7
Make it configurable to use packing or not
guyueh1 80451bd
Merge branch 'yifu/deepseek_ep_main' into guyueh/yifu/deepseek_ep_main
guyueh1 54ff9b5
Merge branch 'yifu/deepseek_ep_main' into guyueh/yifu/deepseek_ep_main
guyueh1 e9953f6
Add two flags for profiling RAY_PROFILING and NEMO_RL_TORCH_PROFILE_R…
guyueh1 114e3b0
Profile refit for one rank one time
guyueh1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest running this code through cursor to simplify the code, var names, typos..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes this is so far a draft, i will do some cleanup