Skip to content

ci: reuse the release-branch container for CI:docs on release PRs #4698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuki-97 merged 1 commit into from
Oct 13, 2026
Merged

ci: reuse the release-branch container for CI:docs on release PRs #4698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .agents/contributor-skills/cicd/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ new container image is built.

| Label | What runs | Container |
|-------|-----------|-----------|
| `CI:docs` | Doc tests only | Reuses main container |
| `CI:docs` | Doc tests only | Reuses main container (PRs to a release branch such as `r0.8.0` reuse that branch's container, same as `CI:Lfast`) |
| `CI:Lfast` | Fast test subset | Reuses main container (PRs to a release branch such as `r0.8.0` reuse that branch's container, published only by pushes to that branch after merges) |
| `CI:L0` | Unit tests + docs + lint | Builds new image |
| `CI:L1` | L0 + functional tests | Builds new image |
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/cicd-main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ on:
- L0
- L1
- L2
description: Test level to run. docs = doc tests only (reuses main container), Lfast = fast subset (reuses main container, or the release branch's container for PRs to a release branch), L0 = unit/docs/lint, L1 = L0 + functional, L2 = L1 + convergence
description: Test level to run. docs = doc tests only (reuses main container, or the release branch's container for PRs to a release branch), Lfast = fast subset (reuses main container, or the release branch's container for PRs to a release branch), L0 = unit/docs/lint, L1 = L0 + functional, L2 = L1 + convergence
test_script_pattern:
description: "Case-insensitive substring used to select unit and functional test script names (for example, Megatron_1 or Vllm)."
required: false
Expand Down Expand Up @@ -289,11 +289,11 @@ jobs:
} | tee -a "$GITHUB_OUTPUT"

# Determine image tag: Lfast and docs reuse a prebuilt container, workflow_dispatch can override.
# Lfast on a release-branch PR reuses that branch's container (published only by builds of the
# release branch itself after merges) because the main container carries main's TRT-LLM wheel,
# Lfast and docs on a release-branch PR reuse that branch's container (published only by builds of
# the release branch itself after merges) because the main container carries main's TRT-LLM wheel,
# not the release branch's. PR builds never overwrite it.
IMAGE_TAG=""
if [[ "$TEST_LEVEL" == "Lfast" && "$IS_PULLREQUEST" == "true" && -n "$CACHE_SCOPE" ]]; then
if [[ ( "$TEST_LEVEL" == "Lfast" || "$TEST_LEVEL" == "docs" ) && "$IS_PULLREQUEST" == "true" && -n "$CACHE_SCOPE" ]]; then
IMAGE_TAG="$CACHE_SCOPE"
elif [[ "$TEST_LEVEL" == "Lfast" || "$TEST_LEVEL" == "docs" ]]; then
IMAGE_TAG="main"
Expand Down
2 changes: 1 addition & 1 deletion docs/ci-cd.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Tests are organized into levels of increasing scope and cost:

| Level | What runs | When |
|-------|-----------|------|
| **docs** | Doctests only | `CI:docs` label |
| **docs** | Doctests only, reuses pre-built main container (skips build); PRs to a release branch (e.g. `r0.8.0`) reuse that branch's container, same as Lfast | `CI:docs` label |
| **L0** | Doctests + unit tests (3 parallel suites: Generation, Policy, Other) | `CI:L0` label |
| **L1** | Doctests + unit tests + functional tests (GPU) | `CI:L1` label, push to main/merge-group |
| **L2** | Full suite including convergence tests | `CI:L2` label |
Expand Down
Loading