Repository navigation
fix(ci): relax grpo-llama3.2-1b-instruct-1n4g-fsdp2tp1.v3 step-time gate to 16s - #4692
Merged
Merged
Conversation
…to 16 Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test ea376e3 |
terrykong
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Relaxes the
grpo-llama3.2-1b-instruct-1n4g-fsdp2tp1.v3step-time gate from 14.5 to 16. Test-script only, no runtime change.What changed
1.
mean(data["timing/train/total_step_time"], -6, -1)bound 14.5 -> 16. The recipe has slowed by ~0.9s since late July. On main CI (nvidia/nemo-rl wandb, 61 runs) the gate value, i.e. the mean over steps 495-499, was:30 of the latest 60 runs exceed 14.5; the max is 15.56.
2. Where the time goes.
prepare_for_generation/totalaccounts for ~0.7s of the slowdown (2.88 -> 3.59);logprob_inference_prepadds ~0.2s.generation,policy_trainingand the logprob phases are flat. Its two instrumented sub-steps (transfer_and_update_weights,sync_policy_params) did not get slower, so the extra time is in the part that is not timed separately.3. Likely trigger, not bisected.
prepare_for_generation/totalis bimodal (~2.9s and ~3.7s). Before 09-28 both modes appear; since then GB200 runs are almost always in the slow mode, starting with the first run atebbc8fdc8(build: bump vllm to 0.29.0, #4080), whose parent window also contains #4129. r0.8.0 includes both. GB300 runs are unaffected (3.3s, gate value 14.18), so only GB200 trips the gate.🤖 Generated with Claude Code