Repository navigation
fix(recipes): enable save_data_plane for PPO async single-controller nightly - #4532
Merged
Merged
Conversation
…nightly Signed-off-by: Yuki Huang <yukih@nvidia.com>
yuki-97
added
cherry-pick-to-main
Contributor
Author
|
/ok to test b0bd3e7 |
yuki-97
enabled auto-merge (squash)
October 6, 2026 09:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes the
ppo-qwen2.5-1.5b-gsm8k-2n8g-megatron-valuetp2sp-dynbatch-noncolocated-async-single-controllernightly by settingcheckpointing.save_data_plane: true. Recipe-only.What changed
The test script turns on
checkpointing.enabled=True, and the recipe'sin_ordersampler is replay-checkpoint-capable (InOrderSampler.supports_buffer_checkpoint = True,nemo_rl/algorithms/async_utils/staleness_sampler.py:564). SC setup rejects that combination unlesssave_data_planeis on (nemo_rl/algorithms/single_controller_utils/setup.py:1120), so the run failed before training. This matchesexamples/configs/ppo_math_1B_megatron_single_controller.yaml, which already sets it.Tests
Validated: the nightly passes with this change.
🤖 Generated with Claude Code