Skip to content

fix(ci): Fix #3589's test broken by #3883 - #3967

Merged
yuki-97 merged 1 commit into
NVIDIA-NeMo:mainfrom
tdene:tde/sc_metrics_dead_shard
Sep 2, 2026
Merged

fix(ci): Fix #3589's test broken by #3883#3967
yuki-97 merged 1 commit into
NVIDIA-NeMo:mainfrom
tdene:tde/sc_metrics_dead_shard

Conversation

@tdene

@tdene tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

@tdene
tdene requested review from a team as code owners September 2, 2026 16:17
@copy-pr-bot

copy-pr-bot Bot commented Sep 2, 2026

Copy link
Copy Markdown

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@tdene tdene added the CI:L0 Run doctests and unit tests label Sep 2, 2026
@tdene

tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 6ff2272

@tdene tdene added CI:L1 Run doctests, unit tests, and functional tests and removed CI:L0 Run doctests and unit tests labels Sep 2, 2026
Signed-off-by: Teodor-Dumitru Ene <teodord.ene@gmail.com>
@tdene tdene added CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version) and removed CI:L1 Run doctests, unit tests, and functional tests labels Sep 2, 2026
@tdene
tdene force-pushed the tde/sc_metrics_dead_shard branch from 6ff2272 to 2b7a136 Compare September 2, 2026 16:33
@tdene

tdene commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 2b7a136

@yuki-97
yuki-97 enabled auto-merge (squash) September 2, 2026 16:47
@yuki-97
yuki-97 merged commit ff7f231 into NVIDIA-NeMo:main Sep 2, 2026
84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI:Lfast Runs a fast test suite and re-use nightly `main` container (but sync dependencies to PRs version)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants