feat(mcore-inference-multimodal): Support multimodal Megatron inference. - #3920
Merged
Conversation
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
4 tasks
Contributor
Author
|
/ok to test 1092610 |
cspades
force-pushed
the
cye/rl_mllm_omni_multimodal
branch
from
August 31, 2026 06:59
1092610 to
f755067
Compare
4 tasks
Contributor
Author
|
/ok to test f755067 |
cspades
force-pushed
the
cye/rl_mllm_omni_multimodal
branch
from
September 1, 2026 21:10
f755067 to
cfa812e
Compare
Contributor
Author
|
/ok to test cfa812e |
cspades
force-pushed
the
cye/rl_mllm_omni_multimodal
branch
from
September 1, 2026 21:44
cfa812e to
7be9e08
Compare
Contributor
Author
|
/ok to test 7be9e08 |
terrykong
previously approved these changes
Sep 2, 2026
terrykong
left a comment
Collaborator
There was a problem hiding this comment.
approved modulo passing pipeline
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Keep main's deduplicated, atomic media encoding behavior in the multimodal module where the branch moved Gym normalization. Signed-off-by: Cory Ye <cye@nvidia.com>
Use the full media model for the inference context while retaining the nested language model for hybrid state and lifecycle operations. Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
…reate a new wrapper for a new config. Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
Signed-off-by: Cory Ye <cye@nvidia.com>
cspades
force-pushed
the
cye/rl_mllm_omni_multimodal
branch
from
September 2, 2026 07:45
7be9e08 to
95b0a89
Compare
Contributor
Author
|
/ok to test 95b0a89 |
terrykong
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Original PR: #3834 (All comments have at least been addressed, that's where we are at.)
CLEVR) and video (VSTAT) accuracy parity with vLLM: https://wandb.ai/adlr/mllm-rl-dev?nw=nwusercye_nvUsage
RL/examples/configs/recipes/vlm/vlm_grpo-nemotron-omni-30ba3b-16n8g-megatron-tp4ep4-async-gym-video.v1.yamlhave been updated to support multimodal generation (if provided a multimodal dataset). Some example MLLM and vLLM parity scripts I used to test with are in a side-branch: https://github.com/cspades/RL/tree/cye/rl_mllm_omni_multimodal_scripts/scriptsGENERATION_BACKEND={vllm,megatron} scripts/submit_nemotron_omni_vstat_megatron_8n4g.shon the Slurm login node orrun_nemotron_omni_clevr_megatron_1n4g.shin an interactive node.Cause I keep forgetting where everything is...
Non-Gym RL Multimodal Data Pipeline
Gym RL Multimodal Data Pipeline
Before your PR is "Ready for review"
Pre checks:
Additional Information