feat(gemma4): add CP recipes and 12B support - #3911
Conversation
4513b4a to
3a52dbf
Compare
|
/ok to test 3a52dbf |
3a52dbf to
e1c593b
Compare
|
/ok to test e1c593b |
e1c593b to
bebe687
Compare
|
/ok to test bebe687 |
|
/ok to test d05ccf7 |
|
/ok to test 2773a4d |
75e25dc to
5223aee
Compare
|
/ok to test 5223aee |
|
Hi @yuki-97 would you help review this PR when you get a chance? Thank you! |
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
5223aee to
31e8be4
Compare
|
/ok to test 31e8be4 |
yuki-97
left a comment
There was a problem hiding this comment.
Overall LGTM. The CP recipes and the 12B gemma4_unified path both look solid, and the CP1-vs-CP2 parity evidence is stronger than most model-enablement PRs ship — a 0.0083 validation-accuracy MAD and a 1.6e-5 generation-KL MAD over 100 aligned steps is exactly the right way to argue a new parallelism axis is a no-op. Thanks also for the self-contained curves in the guide.
Scope: Gemma 4 CP recipes, the 12B gemma4_unified path, and the test-suite/doc changes that ship with them.
Checked:
- vLLM refit path — both refit entry points traced, and the new filter's premise verified against pinned vLLM 0.25.1 source.
- Test drivers — every newly asserted metric key traced to its producer, and each changed threshold compared against its pre-PR form.
- Docs vs code — every support-matrix cell and recipe link checked against the YAML it names.
- Guards, config keys, copyright, docs index, and the nightly budget bump against the repo's own conventions.
Remaining comments are one correctness item on the reload-API refit path, plus four nits on vllm_backend.py and its unit test. Nothing blocking beyond the first.
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
|
/ok to test a304926 |
1 similar comment
|
/ok to test a304926 |
Signed-off-by: Shuang Yu <shuangy@nvidia.com>
|
/ok to test 6c778f4 |
@sharonyu-115, there was an error processing your request: See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/2/ |
|
/ok to test 6c778f4 |
1 similar comment
|
/ok to test 6c778f4 |
|
Verification update for
Both runtime jobs used current head |
|
Hi @yuki-97 Thank you very much for your review and comments. I have addressed all the comments and tested good. Please see the details above. Could you help give another round of review? |
yuki-97
left a comment
There was a problem hiding this comment.
LGTM, thanks @sharonyu-115
What does this PR do?
Adds AutoModel Context Parallel recipes and functional coverage for the Gemma 4 text variants, and adds text-only DAPO support for the Gemma 4 12B unified checkpoint.
google/gemma-4-E2B-it,google/gemma-4-26B-A4B-it, andgoogle/gemma-4-31B-it.google/gemma-4-12B-it.gemma4_unifiedarchitecture through the image-text AutoModel class and ensures vLLM initializes its tokenizer.gemma4_unifiedat runtime.The 12B unified checkpoint is intentionally CP1-only. Its global-attention GQA uses head dimension 512, for which no CP SDPA kernel is available. E2B, 26B-A4B, and 31B use the refactored model-owned CP interface from #3498.
Issues
Closes #2913
Closes #2914
Usage
Run the 12B text-only recipe:
Run the E2B CP2 recipe:
Run the 4-node 26B-A4B EP16 x CP2 recipe:
Validation
Local and static checks:
TEST_DRYRUN=1config resolution: passed.None, empty, causal-only, conditional, and ordered multi-match inputs.git diff --check: passed.GPU functional evidence:
17503334, W&B run IDe2c1a830, completed 100 steps.17503337, W&B run IDe2c2a830, completed 100 steps.0.0083over six aligned validation points.1.6e-5over 100 aligned training steps.g412b200, completed 200 steps across the resumed Slurm segments (16900585,16995049,17503331,17503333).0.540at step 5 to0.617at step 200; maximum0.631.0.166at step 1 to0.054at step 200.6.9e-4.16896034; all 12 applicable tests passed.17620431, W&B run IDg26e16c2innv-welcome/nemo-rl-gemma4. This is pending and is not claimed as passed.Before your PR is "Ready for review"
Pre checks:
Additional Information
9b25508a3.