Skip to content

fix(gym): make the gym venv prefetch dry run pass again - #3819

Merged
yfw merged 1 commit into
super-v3.5-posttrainingfrom
yifu/cherry-pick-48d71a3-super-v3.5
Aug 25, 2026
Merged

fix(gym): make the gym venv prefetch dry run pass again#3819
yfw merged 1 commit into
super-v3.5-posttrainingfrom
yifu/cherry-pick-48d71a3-super-v3.5

Conversation

@yfw

@yfw yfw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Backport 48d71a3 (fix(gym): make the gym venv prefetch dry run pass again #3785) from main onto the current Super v3.5 branch after its Gym bump.
  • Supply required Gym VLLM model fields in the Super and Ultra prefetch configs.
  • Use hardlinks inside the Gym actor so setup scripts using uv --no-cache remain compatible, and add regression validation against Gym config models.

Validation

  • Gym config tests: 7 passed, 2 skipped because the optional vllm extra is unavailable, as documented by the test
  • Targeted pre-commit hooks: passed, including Ruff, Ruff format, Pyrefly, whitespace, and recipe minimization checks
  • git diff --check: passed

Known limitations

  • The full Docker image prefetch was not run locally; the committed test documents the remaining local-vLLM and UV link-mode coverage gaps.

Signed-off-by: Yi-Fu Wu <yifu.wu@gmail.com>
Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
(cherry picked from commit 48d71a3)
@yfw
yfw requested review from a team as code owners August 25, 2026 10:38
@copy-pr-bot

copy-pr-bot Bot commented Aug 25, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@yfw

yfw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test d5ab670

@yfw
yfw merged commit b2c619f into super-v3.5-posttraining Aug 25, 2026
44 of 45 checks passed
@yfw
yfw deleted the yifu/cherry-pick-48d71a3-super-v3.5 branch August 25, 2026 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant