fix(grpo): correct sequence importance ratio metric - #3753
Merged
yuki-97 merged 1 commit intoAug 23, 2026
Conversation
Signed-off-by: Carlos Gomes <cgomes@nvidia.com>
yuki-97
approved these changes
Aug 22, 2026
yuki-97
left a comment
Contributor
There was a problem hiding this comment.
good catch and thanks for the fix!
Contributor
|
/ok to test 45abcca |
yuki-97
enabled auto-merge (squash)
August 22, 2026 14:29
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixes an issue in the metric computation of importance ratio
The issue seems to be that the importance weights are reshaped to [B, 1] in order to be applied to all the tokens in each sequence, but are left that way when they are then reused together with the sample mask. That broadcasts to [B, B]. The whole matrix then gets summed and divided by the number of valid samples, which results in an error. e.g. for 2 samples, both valid the value will be 2x as large as it should be.
The training loss is unnafected, but the metric is wrong
Issues
List issues that this PR closes (syntax):
Usage
# Add a code snippet demonstrating how to use thisBefore your PR is "Ready for review"
Pre checks:
Additional Information