feat(models): add Qwen3.8-27B Megatron support - #3678
Merged
Conversation
zpqiu
force-pushed
the
feat/qwen3.8-27b-mcore
branch
from
August 18, 2026 06:56
6f168ee to
2118cf1
Compare
zpqiu
marked this pull request as ready for review
August 19, 2026 00:35
zpqiu
commented
Aug 19, 2026
zpqiu
left a comment
Contributor
Author
There was a problem hiding this comment.
Review of the Qwen3.8-27B Megatron recipe. Nice addition - the recipe itself is clean, it inherits rather than duplicating the 9B settings, and the guide/model-support.md/toctree wiring is all consistent.
One blocking item: the new nightly puts the suite over the GPU-hour cap, so a unit test that runs in L0 CI fails. Details inline, with the fix that matches how previous nightly-adding PRs handled it.
Verified correct, no action needed:
- Both nightly metric thresholds hold on real 10-step runs (numbers inline).
NUM_MINUTES=60matches fleet convention for 2n8g/10-step Megatron nightlies and has ~43% headroom over measured runtime.- The guide's "context parallelism requires sequence packing" claim is backed by a hard assert at
nemo_rl/models/megatron/setup.py#L862. (docs/model-quirks.md#L29says the opposite, but it's scoped to the FSDP2 section - no conflict.) - TP4 x PP2 x CP2 = 16 = 2 nodes x 8 GPUs;
make_sequence_length_divisible_by: 16is consistent with TP x CP x 2. - Recipe naming,
CONFIG_PATHderivation viacommon.env, and nightly.txt accounting all check out - the other 11 tests intest_recipes_and_test_suites.pypass. - Docs:
> [!NOTE]matches the dominant convention (28 files, incl.qwen3-5.md); all added links resolve; the PNG is 344K, small relative to sibling assets. - No missing model registration - the
qwen3_5special-cases inpolicy/utils.pyandvllm_worker.pyare VLM-only, and Qwen3.8-27B is dense text-only.
Generated by Claude Code
zpqiu
force-pushed
the
feat/qwen3.8-27b-mcore
branch
5 times, most recently
from
August 24, 2026 15:16
73ff19a to
8753083
Compare
sharonyu-115
requested changes
Aug 29, 2026
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
Signed-off-by: Zhaopeng Qiu <alexq@nvidia.com>
zpqiu
force-pushed
the
feat/qwen3.8-27b-mcore
branch
from
August 29, 2026 10:46
8753083 to
fdc6805
Compare
Co-authored-by: sharonyu-115 <shuangy@nvidia.com> Signed-off-by: alexchiu <qiuzhaopeng@foxmail.com>
sharonyu-115
approved these changes
Aug 31, 2026
sharonyu-115
enabled auto-merge (squash)
August 31, 2026 02:55
Contributor
|
/ok to test 38a9f71 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds initial functional support for
Qwen/Qwen3.8-27Bon the Megatron/MCore backend.Issues
Progress toward #3675. This PR covers the Megatron/MCore backend; AutoModel backend validation will follow in a separate PR.
Usage
Validation
bash -n tests/test_suites/llm/grpo-qwen3.8-27b-2n8g-megatron-tp4pp2cp2.shTEST_DRYRUN=1 bash tests/test_suites/llm/grpo-qwen3.8-27b-2n8g-megatron-tp4pp2cp2.shpython3 tools/config_cli.py minimize-check examples/configs/recipes/llm/grpo-qwen3.8-27b-2n8g-megatron-tp4pp2cp2.yamlgit diff --checkBefore your PR is "Ready for review"
Pre checks:
Additional Information
Wandb Link: https://wandb.ai/nvidia/nemorl-pr3678 (including 100-step run and nightly test run).