-
Notifications
You must be signed in to change notification settings - Fork 551
fix: consolidate Megatron Inference tests #3570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
a95bab1
Reshape the megatron-generation functional matrix
tdene f8b3116
Add gen_kl_error to all MInf nightlies
tdene 454852e
Consolidate the megatron-inference nightlies
tdene c56ca9f
Add Blackwell nightly coverage for MInf
tdene 7c50be2
Add small smoke tests to nightly_mcore
tdene 1b88a8c
Fix segment-size on nightlies
tdene 64a5747
Re-enable the multiturn generation test
tdene 79ca861
Fix rebase issues and clean up
tdene 4f2d944
Restore the top-p/top-k parity bound to 1.06
tdene 4c64d2b
Address pr-team comments
tdene 870f487
Address reviewer comments
tdene 4011e93
Fix multiturn token/logprobs mismatch
tdene df44dec
Run MInf_4 leg on Blackwell as well
tdene db049f4
Re-disable broken test
tdene 03b00d2
Fix MXFP8 nightly
tdene 7d382aa
Add step-time gates to MInf nightlies
tdene 72cbdde
Address reviewer comment
tdene 1ee606f
Disable failing tests
tdene 7e7d8e3
Fix multimodal test segment size
tdene File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 0 additions & 41 deletions
41
.../configs/recipes/llm/grpo-llama3.2-1b-instruct-2n8g-megatron_generation-noncolocated.yaml
This file was deleted.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
...es/llm/grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym-quick.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym.yaml | ||
| # Reduced mcore-lane smoke leg: 3 steps, no checkpointing, gen_kl_error-only | ||
| # gate (see the suite). Exists so Megatron-Core/Bridge bumps exercise the 30B | ||
| # megatron-inference stack without paying for the full nightly leg. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym-quick | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym-quick |
36 changes: 36 additions & 0 deletions
36
.../recipes/llm/grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| defaults: ../../../nemo_gym/grpo_nanov3.yaml | ||
| # Async colocated GRPO + gym on Megatron generation with a resharded inference | ||
| # layout: training runs TP2xCP2xEP8 across all 16 GPUs; every wake reshards the | ||
| # weights into TP4xEP4 inference_optimized models on the same GPUs. One nightly | ||
| # covers the async loop with in-flight updates, the gym HTTP ingress, colocated | ||
| # reshard, and (via the suite's save_period=val_period=4) the save-bound | ||
| # deferred-wake path. | ||
| grpo: | ||
| async_grpo: | ||
| enabled: true | ||
| in_flight_weight_updates: true | ||
| overlong_filtering: false | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym | ||
| policy: | ||
| model_name: nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-Base-BF16 | ||
| tokenizer: | ||
| name: nvidia/NVIDIA-Nemotron-3-Nano-30B-A3B-BF16 | ||
| train_global_batch_size: 16 | ||
| max_total_sequence_length: 2048 | ||
| megatron_cfg: | ||
| pipeline_model_parallel_size: 1 | ||
| context_parallel_size: 2 | ||
| generation: | ||
| backend: megatron | ||
| mcore_generation_config: | ||
| tensor_model_parallel_size: 4 | ||
| expert_model_parallel_size: 4 | ||
| logger: | ||
| wandb_enabled: true | ||
| tensorboard_enabled: true | ||
| wandb: | ||
| project: nemo-rl | ||
| name: grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym | ||
| cluster: | ||
| num_nodes: 2 | ||
9 changes: 9 additions & 0 deletions
9
...recipes/llm/grpo-nanov3-30BA3B-2n8g-megatron_generation-noncolocated-async-gym-quick.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-2n8g-megatron_generation-noncolocated-async-gym.yaml | ||
|
yuki-97 marked this conversation as resolved.
|
||
| # Reduced mcore-lane smoke leg: 3 steps, no checkpointing, gen_kl_error-only | ||
| # gate (see the suite). Exists so Megatron-Core/Bridge bumps exercise the 30B | ||
| # megatron-inference stack without paying for the full nightly leg. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-2n8g-megatron_generation-noncolocated-async-gym-quick | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-2n8g-megatron_generation-noncolocated-async-gym-quick | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50 changes: 0 additions & 50 deletions
50
examples/configs/recipes/llm/grpo-nanov3-30BA3B-4n4g-megatron_async_colocated.yaml
This file was deleted.
Oops, something went wrong.
47 changes: 0 additions & 47 deletions
47
examples/configs/recipes/llm/grpo-nanov3-30BA3B-4n4g-megatron_colocated_reshard.yaml
This file was deleted.
Oops, something went wrong.
9 changes: 9 additions & 0 deletions
9
...es/llm/grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym-quick.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym.yaml | ||
| # Reduced mcore-lane smoke leg: 3 steps, no checkpointing, gen_kl_error-only | ||
| # gate (see the suite). Exists so Megatron-Core/Bridge bumps exercise the 30B | ||
| # megatron-inference stack without paying for the full nightly leg. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym-quick | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym-quick |
14 changes: 14 additions & 0 deletions
14
.../recipes/llm/grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-2n8g-megatron_generation-colocated-reshard-async-gym.yaml | ||
| # GB200 sizing: the same 16-GPU layouts on 4-GPU nodes, so the training EP8 | ||
| # groups span two nodes (cross-node expert parallelism, the production | ||
| # Blackwell shape) and placement runs through the NVLink-domain topology path; | ||
| # inference TP4 occupies exactly one node. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-4n4g-megatron_generation-colocated-reshard-async-gym | ||
| cluster: | ||
| gpus_per_node: 4 | ||
| num_nodes: 4 | ||
| segment_size: 2 |
9 changes: 9 additions & 0 deletions
9
...recipes/llm/grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym-quick.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym.yaml | ||
| # Reduced mcore-lane smoke leg: 3 steps, no checkpointing, gen_kl_error-only | ||
| # gate (see the suite). Exists so Megatron-Core/Bridge bumps exercise the 30B | ||
| # megatron-inference stack without paying for the full nightly leg. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym-quick | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym-quick |
19 changes: 19 additions & 0 deletions
19
...nfigs/recipes/llm/grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| defaults: ./grpo-nanov3-30BA3B-2n8g-megatron_generation-noncolocated-async-gym.yaml | ||
| # GB200 sizing: the same 8+8-GPU non-colocated split on 4-GPU nodes, so the | ||
| # training group (CP2xEP8) and the dedicated inference group each span two | ||
| # nodes and placement runs through the NVLink-domain topology path. | ||
| checkpointing: | ||
| checkpoint_dir: results/grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym | ||
| policy: | ||
| generation: | ||
| colocated: | ||
| resources: | ||
| gpus_per_node: 4 | ||
| num_nodes: 2 | ||
| logger: | ||
| wandb: | ||
| name: grpo-nanov3-30BA3B-4n4g-megatron_generation-noncolocated-async-gym | ||
| cluster: | ||
| gpus_per_node: 4 | ||
| num_nodes: 4 | ||
| segment_size: 2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.