Skip to content

ci: bump Megatron-Bridge to 0c565c9a0 #3568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yfw merged 2 commits into from
Aug 11, 2026
Merged

ci: bump Megatron-Bridge to 0c565c9a0 #3568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7ab55a5
chore: bump Megatron-Bridge to 0c565c9a0
tdene Aug 10, 2026
aae969b
Fix isinstance against concrete MFSDP classes
tdene Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion 3rdparty/Megatron-Bridge-workspace/Megatron-Bridge
Open in desktop
Submodule Megatron-Bridge updated 512 files
7 changes: 5 additions & 2 deletions nemo_rl/models/policy/workers/megatron_policy_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,8 @@
from megatron.core.dist_checkpointing.strategies.torch import get_async_strategy
from megatron.core.distributed import DistributedDataParallel
from megatron.core.distributed.fsdp.mcore_fsdp_adapter import (
FullyShardedDataParallel as custom_FSDP,
FullyShardedDataParallelV1,
FullyShardedDataParallelV2,
)
from megatron.core.optimizer import ChainedOptimizer
from megatron.core.rerun_state_machine import get_rerun_state_machine
Expand Down Expand Up @@ -2895,7 +2896,9 @@ def move_model(
raise ValueError(
f"Invalid device: {device}. Only strings 'cpu' and 'cuda' are supported."
)
elif isinstance(model, custom_FSDP):
elif isinstance(
model, (FullyShardedDataParallelV1, FullyShardedDataParallelV2)
):
if device == "cpu":
model.param_and_grad_buffer.offload_to_cpu(move_params, move_grads)
elif device == "cuda":
Expand Down
7 changes: 5 additions & 2 deletions nemo_rl/models/value/workers/megatron_value_worker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,8 @@
from megatron.core import parallel_state
from megatron.core.distributed import DistributedDataParallel
from megatron.core.distributed.fsdp.mcore_fsdp_adapter import (
FullyShardedDataParallel as custom_FSDP,
FullyShardedDataParallelV1,
FullyShardedDataParallelV2,
)
from megatron.core.models.gpt import GPTModel
from megatron.core.optimizer import ChainedOptimizer
Expand Down Expand Up @@ -817,7 +818,9 @@ def move_model(
raise ValueError(
f"Invalid device: {device}. Only 'cpu' and 'cuda' are supported."
)
elif isinstance(model, custom_FSDP):
elif isinstance(
model, (FullyShardedDataParallelV1, FullyShardedDataParallelV2)
):
if device == "cpu":
model.param_and_grad_buffer.offload_to_cpu(move_params, move_grads)
elif device == "cuda":
Expand Down
Loading
Loading