feat(rollout): add periodic partial-rollout recovery snapshots - #3508
Draft
macandro96 wants to merge 4 commits into
Draft
feat(rollout): add periodic partial-rollout recovery snapshots#3508macandro96 wants to merge 4 commits into
macandro96 wants to merge 4 commits into
Conversation
macandro96
force-pushed
the
amahishi/partial-rollout-ledger
branch
from
August 5, 2026 23:37
1f5b0be to
ff78ebe
Compare
macandro96
force-pushed
the
amahishi/partial-rollout-ledger
branch
from
August 10, 2026 19:39
b2a048c to
c1fdb07
Compare
macandro96
force-pushed
the
amahishi/partial-rollout-ledger
branch
from
August 10, 2026 22:57
c1fdb07 to
18d67cd
Compare
This was referenced Aug 11, 2026
macandro96
force-pushed
the
amahishi/partial-rollout-ledger
branch
from
August 20, 2026 15:28
18d67cd to
f1d8ad0
Compare
Add periodic TQ, replay, lineage, and dataloader snapshots anchored to durable trainer state. Roll back groups claimed by an unfinished optimizer step into replayable state during persistence, restore them on restart, and cover partial-sibling plus 2/8 and 6/8 streamed recovery paths. (cherry picked from commit 98c196f)
Set checkpointing.metric_name=null in every SC recovery harness that enables checkpointing, since SC has no validation loop. Include phase-one log tails when crash-driven recovery tests exit before producing their target snapshot. (cherry picked from commit a5e9a16)
(cherry picked from commit 4cd773d)
(cherry picked from commit f1d8ad0)
macandro96
force-pushed
the
amahishi/partial-rollout-ledger
branch
from
August 24, 2026 21:03
f1d8ad0 to
9355cc5
Compare
Contributor
Author
|
Will be superseded by #3924 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds frequent partial-rollout snapshots and makes streamed optimizer steps recoverable from their last durable trainer anchor.
rollout_checkpointing.interval_s,keep_latest_k, andrestore_mode.COMMITTED, atomic rename, and an atomically updatedLATESTpointer.FINALIZEDownership, so restart discards uncheckpointed gradients and replays the complete step from its durable trainer anchor.Stack
Configuration
interval_s: nulldisables periodic rollout snapshots.Bootstrap snapshots live under
bootstrap/rollout_snapshots/; later snapshots live under the matching durablestep_N/rollout_snapshots/anchor.Streamed-step recovery
If a snapshot is taken after 2 of 8 prompt groups have contributed uncommitted gradients, the snapshot retains those rows as replayable finalized ownership. Restart loads the durable trainer anchor, discards the uncheckpointed 2/8 gradients, and trains all eight groups exactly once.
Validation