fix(sc): log config parameters to W&B - #3465
Merged
Merged
Conversation
Contributor
Author
|
/ok to test 74988d5 |
Signed-off-by: ruit <ruit@nvidia.com>
RayenTian
force-pushed
the
ruit/fix-sc-wandb-config
branch
from
August 3, 2026 06:18
74988d5 to
fb2c7eb
Compare
Contributor
Author
|
/ok to test fb2c7eb |
RayenTian
added
the
CI:Lfast
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Log the resolved SingleController master config as hyperparameters so W&B runs display config parameters in the Overview page, matching the existing training entrypoints.
Update SingleController test fixtures to use the real
ClippedPGLossConfig, allowing the Pydantic master config to serialize correctly, and verify that hyperparameters are logged during actor initialization.Issues
Before:
Now
Usage
Launch a SingleController recipe with W&B enabled. The resolved config parameters will be available in the W&B run Overview.
Before your PR is "Ready for review"
Pre checks:
Additional Information
git diff --check origin/main...HEADpasses.