-
Notifications
You must be signed in to change notification settings - Fork 527
perf: enable HybridEP on H100/B200 x86 systems #3436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
e0a23cc
589375e
79f66b3
799351f
6ba59a8
a9aaa39
2e516bc
1261ded
d59c125
34e8acf
98d4b53
adb76f7
04b1cf7
919a6d1
0f35695
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -132,17 +132,15 @@ automodel = [ | |||||||||||||||||||||
| "causal-conv1d", | ||||||||||||||||||||||
| "nv-grouped-gemm", | ||||||||||||||||||||||
| "transformer-engine[pytorch,core_cu13] @ git+https://github.com/NVIDIA/TransformerEngine.git@v2.14.1", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@29d31c095796f3c8ece47ee9cdcc167051bbeed9 ; platform_machine == 'x86_64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@a48493600c4886c1b297aaa78db0e1ebc2d8dd6c ; platform_machine == 'aarch64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@17cfb817bccec3a9c247013360cc550c2bac441e", | ||||||||||||||||||||||
| ] | ||||||||||||||||||||||
| vllm = [ | ||||||||||||||||||||||
| "cuda-python", | ||||||||||||||||||||||
| "deep_gemm @ git+https://github.com/deepseek-ai/DeepGEMM.git@67fc64863d43521080bf2005e6528d0fceee9510", | ||||||||||||||||||||||
| # deep_ep also needs libibverbs-dev | ||||||||||||||||||||||
| # sudo apt-get update | ||||||||||||||||||||||
| # sudo apt-get install libibverbs-dev | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@29d31c095796f3c8ece47ee9cdcc167051bbeed9 ; platform_machine == 'x86_64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@a48493600c4886c1b297aaa78db0e1ebc2d8dd6c ; platform_machine == 'aarch64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@17cfb817bccec3a9c247013360cc550c2bac441e", | ||||||||||||||||||||||
| # Default wheels on GitHub are cu130. See v0.25.1 release assets: | ||||||||||||||||||||||
| # https://github.com/vllm-project/vllm/releases/tag/v0.25.1 | ||||||||||||||||||||||
| "vllm @ https://github.com/vllm-project/vllm/releases/download/v0.25.1/vllm-0.25.1-cp38-abi3-manylinux_2_28_aarch64.whl ; sys_platform == 'linux' and platform_machine == 'aarch64'", | ||||||||||||||||||||||
|
|
@@ -193,8 +191,7 @@ mcore = [ | |||||||||||||||||||||
| # silently falls back to the PyPI releases instead of the pinned git revs. | ||||||||||||||||||||||
| "mamba-ssm", | ||||||||||||||||||||||
| "causal-conv1d", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@29d31c095796f3c8ece47ee9cdcc167051bbeed9 ; platform_machine == 'x86_64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@a48493600c4886c1b297aaa78db0e1ebc2d8dd6c ; platform_machine == 'aarch64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@17cfb817bccec3a9c247013360cc550c2bac441e", | ||||||||||||||||||||||
| "flashinfer-python==0.6.8.post1", | ||||||||||||||||||||||
| "flashinfer-cubin==0.6.8.post1", | ||||||||||||||||||||||
| "flashinfer-jit-cache==0.6.8.post1", | ||||||||||||||||||||||
|
|
@@ -367,8 +364,7 @@ override-dependencies = [ | |||||||||||||||||||||
| "llguidance>=1.3.0,<1.4.0", | ||||||||||||||||||||||
| # Override setuptools range in other dependencies to address CVE GHSA-58pv-8j8x-9vj2 | ||||||||||||||||||||||
| "setuptools>=80.10.2", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@29d31c095796f3c8ece47ee9cdcc167051bbeed9 ; platform_machine == 'x86_64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@a48493600c4886c1b297aaa78db0e1ebc2d8dd6c ; platform_machine == 'aarch64'", | ||||||||||||||||||||||
| "deep_ep @ git+https://github.com/deepseek-ai/DeepEP.git@17cfb817bccec3a9c247013360cc550c2bac441e", | ||||||||||||||||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On GB200, two things would help close the "Validation boundary" gap:
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks — I re-checked the provenance. For H100, multi-node runtime validation used the exact, unpatched DeepEP pin
W&B history was re-checked and contains train steps 1–20 for all three H100 runs. The multi-node flag is a build-time requirement at this pin; #3436 selects the source revision but does not itself rebuild an existing single-node DeepEP binary. Job Separately, a 4-node × 8-GPU B200 Qwen3-30B-A3B run used an exact, unpatched wheel built from The local DMA-BUF fallback was an experimental workaround for |
||||||||||||||||||||||
| # Relax megatron-core workspace member's opentelemetry-api ceiling (<1.34) for protobuf 6.x compat with ray | ||||||||||||||||||||||
| "opentelemetry-api>=1.33.1", | ||||||||||||||||||||||
| # Override sglang's xgrammar==0.1.32 to address CVE GHSA-7rgv-gqhr-fxg3. | ||||||||||||||||||||||
|
|
@@ -552,7 +548,7 @@ requires-dist = ["torch", "packaging", "ninja", "causal-conv1d"] | |||||||||||||||||||||
| [[tool.uv.dependency-metadata]] | ||||||||||||||||||||||
| name = "deep_ep" | ||||||||||||||||||||||
| # This version has to match the version in the commit/rev/tag used | ||||||||||||||||||||||
| version = "v1.2.1+29d31c0" | ||||||||||||||||||||||
| version = "1.2.1+17cfb81" | ||||||||||||||||||||||
| requires-dist = ["torch", "packaging", "ninja"] | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
| [[tool.uv.dependency-metadata]] | ||||||||||||||||||||||
|
|
||||||||||||||||||||||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would help to link an H100 run of one existing DeepEP recipe on pin
17cfb817in the PR body — e.g.tests/test_suites/llm/grpo-qwen3.5-35ba3b-2n8g-automodel-ep16.sh.None of the L0 / fast-L1 tiers turn on DeepEP, so their
successhere does not cover the actual path this bump touches.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember previously
grpo-qwen3.5-35ba3b-2n8g-automodel-ep16had some issue before bump deep_ep to29d31c095796f3c8ece47ee9cdcc167051bbeed9in #2224, so it's good to have a test on this.