fix: fix dapo-deepseek-v3-64n8g.v2 and dsv3 tokenizer - #3154
Merged
Conversation
Signed-off-by: Yuki Huang <yukih@nvidia.com>
Contributor
Author
|
/ok to test da580b9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Fix
dapo-deepseek-v3-64n8g.v2Update
num_prompts_per_step * num_generations_per_promptfrom 64 * 8 to 32 * 16.The dynamic-sampling fix in #2478 filters more samples than before. With
num_generations_per_prompt=8, samples are easily filtered and most runs approach the max allowed number of batches (10), triggering the 4h timeout. Some runs also fail with:Raising
num_generations_per_promptto 16 gives enough within-group diversity.2. Fix DSV3 tokenizer
The Moonlight tokenizer fix in #3116 breaks DSV3. Narrow the scope of the Moonlight patch so it only kicks in when the default
AutoTokenizer.from_pretrainedpath fails.Tests
Validated below tests passed.
dapo-deepseek-v3-64n8g.v2grpo-moonlight-16b-automodel-1n8g-ep8Note
dapo-deepseek-v3-64n8g.v2is fixed inr0.7.0branch, but will easily meet the below error in main branch. tracked in #3155.(MegatronPolicyWorker pid=1391870) [2026-07-10 06:19:36] pool0-00008:1391870:1393239 [7] init.cc:904 NCCL WARN Duplicate GPU detected : rank 15 and rank 7 both on CUDA device e4000